[#31836] - Action logs fix for media manager upload urls
- Fixed in Code Base
- 7 May 2021
- Medium
- Build: staging
- # 31836
- Diff
- wilsonge:media_manager_uploads
User tests: Successful: Unsuccessful:
Pull Request for Issue #30951 .
Summary of Changes
Fixes URLs generated in the action logs plugin from the media component. Involves passing the JObject generated by a component back through however - as the id of the media (always 0) is completely useless as the current parameter.
Testing Instructions
Upload an item into the media manager. Before the patch the link on the file name uploaded will be invalid. After patching the link will correctly take you to the folder of the uploaded item.
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_media Front End Plugins |
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31836.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31836.
B/C break in a patch release?
| Status | Ready to Commit | ⇒ | Pending |
Back to pending, information required regarding B/C.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31836.
@SharkyKZ whats a b/c break here? Adding the extra parameter to the component method isn’t a b/c break.
The extra param to the ActionLogsHelper I guess is what you’re referring to? But it’s not a method we’d expect to be called by 3rd parties and we don’t have a b/c guarantee on extensions anyhow
I’m happy to change the target to 3.10 though
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31836.
OK for me.
@HLeithner Shall I remove RTC again?
yes please
| Status | Ready to Commit | ⇒ | Pending |
Back to pending.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31836.
This is still broken in Joomla 4 beta 7
Today
@HLeithner better with wilsonge#64 ?
or still not accettable in a minor version ?
Yes better
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31836.
imho it should go on the next 3.9.x and then upmerged it's a bug
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31836.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31836.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-07 13:53:29 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
|
||
Thanks
I have tested this item✅ successfully on dd8dc60
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31836.