[#31835] - [4.0] Ensure language code is validated in the mail template
- Fixed in Code Base
- 2 Jan 2021
- Medium
- Build: 4.0-dev
- # 31835
- Diff
- wilsonge:feature/validate-mail-language
User tests: Successful: Unsuccessful:
Pull Request for Issue #30957 .
Summary of Changes
Ensure there is a valid language code for an application when saving.
Testing Instructions
You can't follow the instructions in the issue anymore as another PR has disabled the ability to navigate directly to the edit form. However you can reproduce by editing the form directly (as below) - this screenshot also shows the expected error when you save an item with an invalid language code:
Actual result BEFORE applying this Pull Request
Result saves or gives database error
Expected result AFTER applying this Pull Request
Error message as in the above screenshot
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
| Title |
|
||||||
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings |
I have tested this item
Save without the patch gave: Save failed with the following error: Data too long for column 'language' at row 1
With the patch it gave: Invalid Language Code
That link with a drop down arrow to the right I found confusing. Better to make it a more obvious button?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31835.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31835.
| Labels |
Added:
?
?
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-01-02 14:43:01 |
| Closed_By | ⇒ | drmenzelit | |
| Labels | |||
Thanks
I have tested this item✅ successfully on 0aed636
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31835.