NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
1 Jan 2021

Pull Request for Issue #31816

Summary of Changes

.length is unecessary in the js

Testing Instructions

Create a category blog menu item.
Look at console.

Actual result BEFORE applying this Pull Request

Uncaught TypeError: MediaXTDElements is undefined
    <anonymous> http://localhost:8888/newfolder/joomla40/media/system/js/fields/joomla-image-select.js:401
    <anonymous> http://localhost:8888/newfolder/joomla40/media/system/js/fields/joomla-image-select.js:413
joomla-image-select.js:401:9

Expected result AFTER applying this Pull Request

No more uncaught error.

Explanation

The error will not show when the Editor is one of the fields loaded in the page (which ever it is), because the image XTD is available through the CMS Content => Image.
Blog, for example, has no Editor, but contains some media fields.

avatar infograf768 infograf768 - open - 1 Jan 2021
avatar infograf768 infograf768 - change - 1 Jan 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 Jan 2021
Category JavaScript Repository NPM Change
avatar joeforjoomla
joeforjoomla - comment - 1 Jan 2021

I have tested this item successfully on 683bf09


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31819.

avatar joeforjoomla joeforjoomla - test_item - 1 Jan 2021 - Tested successfully
avatar richard67
richard67 - comment - 2 Jan 2021

I have tested this item successfully on 683bf09


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31819.

avatar richard67 richard67 - test_item - 2 Jan 2021 - Tested successfully
avatar richard67 richard67 - change - 2 Jan 2021
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 2 Jan 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31819.

avatar richard67 richard67 - change - 2 Jan 2021
Labels Added: ? ? NPM Resource Changed
avatar drmenzelit drmenzelit - change - 2 Jan 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-01-02 18:42:45
Closed_By drmenzelit
Labels
avatar drmenzelit drmenzelit - close - 2 Jan 2021
avatar drmenzelit drmenzelit - merge - 2 Jan 2021
avatar drmenzelit
drmenzelit - comment - 2 Jan 2021

Thanks

avatar joeforjoomla
joeforjoomla - comment - 6 Jan 2021

Not sure if this has been merged but tried today the latest 4.0 beta 6 dev and the issue is still there, the file is not updated.

avatar infograf768
infograf768 - comment - 6 Jan 2021
avatar joeforjoomla
joeforjoomla - comment - 6 Jan 2021

Strange, i've ran the auto updater to reinstall core files but it's still wrong. The same on Github.

avatar richard67
richard67 - comment - 6 Jan 2021

@joeforjoomla Regarding Github: Did you use your fork of joomla_cms? In this case your 4.0-dev branch needs to be updated to the one of the CMS repository.

Add a Comment

Login with GitHub to post a comment