NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
29 Dec 2020

Successor PR to #31692 which doesn't work on Mac

There is a node command to gzip the assets

npm run gzip

When testing on windows it doesn't work although does on Mac

After applying this PR then running the same command and it will work. (note it will appear to hang at the end - just be patient its slow)

avatar wilsonge wilsonge - open - 29 Dec 2020
avatar wilsonge wilsonge - change - 29 Dec 2020
Status New Pending
avatar wilsonge wilsonge - change - 29 Dec 2020
Title
Move gzip command to work on windows
[4.0] Move gzip command to work on windows
avatar wilsonge wilsonge - edited - 29 Dec 2020
avatar joomla-cms-bot joomla-cms-bot - change - 29 Dec 2020
Category JavaScript Repository NPM Change
avatar dgrammatiko
dgrammatiko - comment - 29 Dec 2020

I have tested this item successfully on fa39d9f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31800.

avatar dgrammatiko dgrammatiko - test_item - 29 Dec 2020 - Tested successfully
avatar wilsonge wilsonge - change - 29 Dec 2020
Labels Added: NPM Resource Changed ?
avatar brianteeman
brianteeman - comment - 29 Dec 2020

(note it will appear to hang at the end - just be patient its slow)

Beyond slow - a tortoise is faster. Can't there be any console output?

Otherwise it works ok

avatar dgrammatiko
dgrammatiko - comment - 29 Dec 2020

Beyond slow - a tortoise is faster. Can't there be any console output?

Well if it was way faster the output would be irrelevant (unless there's an error). BTW #31635 is many times faster than the synchronous WASM code used atm (WASM was used because zopfli didn't had a 32bit binary so the Drone was failing, a sad story but then again this was the only place that Joomla actually used WASM)...

avatar wilsonge wilsonge - change - 30 Dec 2020
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-12-30 21:57:56
Closed_By wilsonge
avatar wilsonge wilsonge - close - 30 Dec 2020
avatar wilsonge wilsonge - merge - 30 Dec 2020

Add a Comment

Login with GitHub to post a comment