NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar bembelimen
bembelimen
28 Dec 2020

Pull Request for Issue #31741 .

Summary of Changes

Fix movecopy JS in field list
Rename movecopy JS to "movecopy" instead of "language"
Update webassets (remove from language add to movecopy)

Testing Instructions

In general follow: #31741 but as this also renames the file and loads it on a different place, go through all "move & copy" batch functions and test if they still work

Actual result BEFORE applying this Pull Request

Javascript error

Expected result AFTER applying this Pull Request

No Javascript error

avatar bembelimen bembelimen - open - 28 Dec 2020
avatar bembelimen bembelimen - change - 28 Dec 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Dec 2020
Category Administration com_fields com_menus com_modules com_users JavaScript Repository NPM Change Layout
avatar infograf768
infograf768 - comment - 28 Dec 2020

No more Uncaught Error.

avatar bembelimen bembelimen - change - 28 Dec 2020
Labels Added: NPM Resource Changed ?
avatar infograf768
infograf768 - comment - 29 Dec 2020

I have tested this item successfully on 6b12556


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31791.

avatar infograf768 infograf768 - test_item - 29 Dec 2020 - Tested successfully
avatar gostn
gostn - comment - 29 Dec 2020

I have tested this item successfully on 6b12556


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31791.

avatar gostn gostn - test_item - 29 Dec 2020 - Tested successfully
avatar infograf768
infograf768 - comment - 29 Dec 2020

@gostn
Have you tested go through all "move & copy" batch functions and test if they still work ?
Have you used npm ?

avatar gostn
gostn - comment - 29 Dec 2020

why asking?

avatar infograf768
infograf768 - comment - 29 Dec 2020

Just to be sure as it took quite some time for me to test all possibilities.

avatar gostn
gostn - comment - 29 Dec 2020

Why you assume i don't take time for test like you?

avatar chmst chmst - change - 29 Dec 2020
Status Pending Ready to Commit
avatar chmst
chmst - comment - 29 Dec 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31791.

avatar infograf768 infograf768 - change - 29 Dec 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-12-29 16:55:57
Closed_By infograf768
Labels Added: ?
avatar infograf768 infograf768 - close - 29 Dec 2020
avatar infograf768 infograf768 - merge - 29 Dec 2020
avatar infograf768
infograf768 - comment - 29 Dec 2020

tks

Add a Comment

Login with GitHub to post a comment