? ? Pending

User tests: Successful: Unsuccessful:

avatar bembelimen
bembelimen
27 Dec 2020

Pull Request for Issue #31782 .

Summary of Changes

Fix broken suggestion dropdown of smart search

Testing Instructions

See #31782

Actual result BEFORE applying this Pull Request

Suggestions do not work

Expected result AFTER applying this Pull Request

Suggestions work.

avatar bembelimen bembelimen - open - 27 Dec 2020
avatar bembelimen bembelimen - change - 27 Dec 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 27 Dec 2020
Category Front End com_finder
avatar bembelimen bembelimen - change - 28 Dec 2020
Title
Fix broken finder suggestion
[4.0] Fix broken finder suggestion
avatar bembelimen bembelimen - edited - 28 Dec 2020
avatar infograf768
infograf768 - comment - 28 Dec 2020

@bembelimen
Works fine here. :)
You can now take off use Joomla\String\StringHelper; as it is no use anymore.

avatar bembelimen bembelimen - change - 28 Dec 2020
Labels Added: ?
avatar infograf768
infograf768 - comment - 28 Dec 2020

I have tested this item successfully on b4b52ad


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31788.

avatar infograf768 infograf768 - test_item - 28 Dec 2020 - Tested successfully
avatar gostn
gostn - comment - 28 Dec 2020

I have tested this item successfully on b4b52ad


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31788.

avatar gostn gostn - test_item - 28 Dec 2020 - Tested successfully
avatar richard67 richard67 - change - 28 Dec 2020
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 28 Dec 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31788.

avatar wilsonge wilsonge - close - 29 Dec 2020
avatar wilsonge wilsonge - merge - 29 Dec 2020
avatar wilsonge wilsonge - change - 29 Dec 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-12-29 04:05:16
Closed_By wilsonge
Labels Added: ?
avatar wilsonge
wilsonge - comment - 29 Dec 2020

Thanks for fixing my merge conflicts!

Add a Comment

Login with GitHub to post a comment