? ? Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
20 Dec 2020

Pull Request as a helping hand for #30056 and #31735.

Summary of Changes

  • The tool is now creating 4 pages, incompatible, noxml, fatal and incomplete
  • The files are moved to media/system as these are static files
  • Fixed all the paths for this change

Testing Instructions

Run npm install or node build/build.js --build-pages from the root path of your Joomla cloned repo
Check /templates/system for 4 html files: incompatible, noxml, fatal-error and build_incomplete
Open each in your browser (double click also works here)
You should have these:
Screenshot 2020-12-20 at 21 17 57
Screenshot 2020-12-20 at 21 18 07
Screenshot 2020-12-20 at 21 18 17
Screenshot 2020-12-20 at 21 18 26

Testing the actual php requires some editing of files (that's because it needs to kick the error):

  • Front end change < to >
    if (version_compare(PHP_VERSION, JOOMLA_MINIMUM_PHP, '<'))
    and check your front end (eg localhost/)
  • Back end change < to >
    if (version_compare(PHP_VERSION, JOOMLA_MINIMUM_PHP, '<'))
    and check your front end (eg localhost/)
  • Installation change < to >
    if (version_compare(PHP_VERSION, JOOMLA_MINIMUM_PHP, '<'))
    also rename your root configuration.php to configuration.back and check your front end (eg localhost/)
  • Installation change /media/vendor to /media/notexisting
    if (!file_exists(JPATH_LIBRARIES . '/vendor/autoload.php') || !is_dir(JPATH_ROOT . '/media/vendor'))
    also rename your root configuration.php to configuration.back and check your front end (eg localhost/)

There are also 2 more cases that require this PR to be merge, then pull #30056 and 31735 and follow the testing instructions on these PR's

That's all.

avatar dgrammatiko dgrammatiko - open - 20 Dec 2020
avatar dgrammatiko dgrammatiko - change - 20 Dec 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Dec 2020
Category Administration JavaScript Repository NPM Change Installation Language & Strings Front End Templates (site)
avatar dgrammatiko dgrammatiko - change - 20 Dec 2020
The description was changed
avatar dgrammatiko dgrammatiko - edited - 20 Dec 2020
avatar dgrammatiko dgrammatiko - change - 20 Dec 2020
Labels Added: ? NPM Resource Changed ?
avatar brianteeman
brianteeman - comment - 20 Dec 2020

Just add your suggestion to this PR and I will close my pr

avatar dgrammatiko dgrammatiko - change - 23 Dec 2020
The description was changed
avatar dgrammatiko dgrammatiko - edited - 23 Dec 2020
avatar dgrammatiko dgrammatiko - change - 23 Dec 2020
The description was changed
avatar dgrammatiko dgrammatiko - edited - 23 Dec 2020
avatar dgrammatiko dgrammatiko - change - 2 Jan 2021
Labels Added: Conflicting Files
avatar PhilETaylor
PhilETaylor - comment - 2 Feb 2021

I have a vested interest in getting this merged so that I can get my PR based on this work merged...

Are we stalled again?

avatar dgrammatiko
dgrammatiko - comment - 3 Feb 2021

@PhilETaylor this PR has conflicts, I'll try to update it tomorrow

avatar PhilETaylor
PhilETaylor - comment - 3 Feb 2021

Thanks :) no rush.. appreciate your work which makes my PR a million times easier to implement.

90d5eeb 25 Feb 2021 avatar dgrammatiko redo
avatar dgrammatiko dgrammatiko - change - 25 Feb 2021
Labels Removed: Conflicting Files
avatar joomla-cms-bot joomla-cms-bot - change - 25 Feb 2021
Category Administration JavaScript Repository NPM Change Installation Language & Strings Front End Templates (site) Administration JavaScript Repository Installation Language & Strings Front End Templates (site)
avatar dgrammatiko
dgrammatiko - comment - 25 Feb 2021

Commit 90d5eeb

  • resolves conflicts
  • reverts the moving of the produced pages to the media folder
avatar dgrammatiko dgrammatiko - change - 25 Feb 2021
The description was changed
avatar dgrammatiko dgrammatiko - edited - 25 Feb 2021
avatar wilsonge wilsonge - change - 25 Feb 2021
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-02-25 16:32:38
Closed_By wilsonge
Labels Removed: NPM Resource Changed
avatar wilsonge wilsonge - close - 25 Feb 2021
avatar wilsonge wilsonge - merge - 25 Feb 2021
avatar wilsonge
wilsonge - comment - 25 Feb 2021

This looks ok to me. Thanks!

Add a Comment

Login with GitHub to post a comment