User tests: Successful: Unsuccessful:
Pull Request as a helping hand for #30056 and #31735.
media/system
as these are static filesRun npm install
or node build/build.js --build-pages
from the root path of your Joomla cloned repo
Check /templates/system
for 4 html files: incompatible, noxml, fatal-error and build_incomplete
Open each in your browser (double click also works here)
You should have these:
Testing the actual php requires some editing of files (that's because it needs to kick the error):
<
to >
Line 18 in f637260
<
to >
joomla-cms/administrator/index.php
Line 18 in f637260
<
to >
joomla-cms/installation/index.php
Line 18 in f637260
/media/vendor
to /media/notexisting
joomla-cms/installation/includes/app.php
Line 18 in f637260
There are also 2 more cases that require this PR to be merge, then pull #30056 and 31735 and follow the testing instructions on these PR's
That's all.
Status | New | ⇒ | Pending |
Category | ⇒ | Administration JavaScript Repository NPM Change Installation Language & Strings Front End Templates (site) |
Labels |
Added:
?
NPM Resource Changed
?
|
Labels |
Added:
Conflicting Files
|
I have a vested interest in getting this merged so that I can get my PR based on this work merged...
Are we stalled again?
@PhilETaylor this PR has conflicts, I'll try to update it tomorrow
Thanks :) no rush.. appreciate your work which makes my PR a million times easier to implement.
Labels |
Removed:
Conflicting Files
|
Category | Administration JavaScript Repository NPM Change Installation Language & Strings Front End Templates (site) | ⇒ | Administration JavaScript Repository Installation Language & Strings Front End Templates (site) |
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-02-25 16:32:38 |
Closed_By | ⇒ | wilsonge | |
Labels |
Removed:
NPM Resource Changed
|
This looks ok to me. Thanks!
Just add your suggestion to this PR and I will close my pr