[#31737] - [4.0 newsfeed character count
- Closed
- 3 Feb 2021
- Medium
- Build: 4.0-dev
- # 31737
- Diff
- brianteeman:newsfeed
User tests: Successful: Unsuccessful:
It is not a word count. string.truncate is a character count (and a trim to prevent partial words)
Create a newsfeed module with the following example feed https://www.nytimes.com/svc/collections/v1/publish/https://www.nytimes.com/section/world/rss.xml
Leave the character count at 0 and you have the full feed
retest with the character count at 10 and you have approx 10 characters depenant on word breaks
Pull Request for Issue #29741
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Language & Strings Modules Front End |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31737.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31737.
This works, but I guess you are aware that this is not B/C because the field name is modified and therefore existing modules will default to 0.
Not my decision to merge.
@wilsonge @HLeithner
Good point about the changed field name. I didnt consider that. At least its only a cosmetic b/c change
I am happy to change it back but would prefer to keep the change so that the code is more meaningful
I leave it to others to decide
Please advise how to proceed to resolve and fix this bug
No point in keeping this open
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-02-03 19:34:17 |
| Closed_By | ⇒ | brianteeman | |
| Labels |
Added:
?
?
|
||
I have tested this item✅ successfully on 5f9b207
Tested successfully in Beta6-dev of 21 December.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31737.