[#31736] - [4.0] COM_INSTALLER_MSG_WARNINGS_SMALLUPLOADSIZEDESC
- Fixed in Code Base
- 5 Jan 2021
- Medium
- Build: 4.0-dev
- # 31736
- Diff
- brianteeman:postmax
User tests: Successful: Unsuccessful:
Clarify the message in accordance with php.net
pr for #30098
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31736.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31736.
Looks like we have 2 contradictory tips here.
This patch
COM_INSTALLER_MSG_WARNINGS_SMALLUPLOADSIZEDESC="The maximum file size for uploads is set to less than 8MB which may impact on uploading large extensions. This is set in php.ini in both the upload_max_filesize and post_max_size settings of your PHP settings (located in php.ini and/or .htaccess file). The value of post_max_size must be greater than the value of upload_max_filesize."
but we have below:
COM_INSTALLER_MSG_WARNINGS_UPLOADBIGGERTHANPOSTDESC="The value of the upload_max_filesize in the php.ini file is greater than the post_max_size variable. The post_max_size variable will take precedence and block requests larger than it. This is generally a server misconfiguration when trying to increase upload sizes. Please increase the upload_max_filesize to at least match the post_max_size variable or vice versa."
| Status | Ready to Commit | ⇒ | Pending |
Moved back to pending because of #31736 (comment)
Maybe I need coffee but where is the contradiction?
The value of post_max_size must be greater than the value of upload_max_filesize.
vs
Please increase the upload_max_filesize to at least match the post_max_size variable or vice versa.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31736.
| Status | Ready to Commit | ⇒ | Pending |
Back to pending.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31736.
@brianteeman The contradiction is that COM_INSTALLER_MSG_WARNINGS_SMALLUPLOADSIZEDESC says that the value of post_max_size must be greater than the value of upload_max_filesize, while the other text COM_INSTALLER_MSG_WARNINGS_UPLOADBIGGERTHANPOSTDESC says "Please increase the upload_max_filesize to at least match the post_max_size variable or vice versa.", and that first includes that the upload_max_filesize should be greater than or equal to the post_max_size and then confuses with the "or vice versa".
Both is wrong. True is that the value of post_max_size must be greater than or equal to the value of upload_max_filesize. See here for an explanation: https://stackoverflow.com/questions/7754133/php-post-max-size-overrides-upload-max-filesize.
This PR is correct and follows the documentation at php.net. If you want to change the other string then that should be done in its own PR
Brians PR is correct but the description in "COM_INSTALLER_MSG_WARNINGS_UPLOADBIGGERTHANPOSTDESC" is wrong and should be fixed
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31736.
| Labels |
Added:
?
?
|
||
Brians PR is correct but the description in "COM_INSTALLER_MSG_WARNINGS_UPLOADBIGGERTHANPOSTDESC" is wrong and should be fixed
RANT: It was so simple to do it here instead of a new PR!!! I can't believe this. I asked for it 13 days ago...
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-01-05 07:30:48 |
| Closed_By | ⇒ | infograf768 | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 430cfd4
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31736.