Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#31688] - Add a hidden menuItem Search to blog sample data

? ? Pending

User tests: Successful: Unsuccessful:

avatar chmst
chmst
17 Dec 2020

Pull Request for Issue #31678 .

Summary of Changes

Add a menuItem Search to the bottom Menu, make this a horizontal menu.

@brianteeman r- adding / removing modules is kind of difficult, especially for module set in the installation process or by multilingual sample data. This could be another PR.

Testing Instructions

On a clean j4 installation install the blog sample data.
Enter a searchstring into the search module and press search.

Actual result BEFORE applying this Pull Request

as described in #31678, a long url is generated

Expected result AFTER applying this Pull Request

The url is like /index.php/search?q=adsf

avatar chmst chmst - open - 17 Dec 2020
avatar chmst chmst - change - 17 Dec 2020
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Dec 2020
Category ⇒ Administration Language & Strings Front End Plugins
avatar brianteeman
brianteeman - comment - 17 Dec 2020

I think you misunderstood me about modules - I wasnt suggesting adding or removing any

As for the menu item my suggestion was for it to be a HIDDEN menu item within the main menu. This way it showcased the hidden menu item feature as well as fixing the SEF url

avatar infograf768
infograf768 - comment - 17 Dec 2020

This patch correctly adds a hidden search menu in the Bottom menu. It is not a new module afaik.

Screen Shot 2020-12-17 at 17 10 13

Screen Shot 2020-12-17 at 17 11 41

we correctly get a link of the type
http://localhost:8888/sample/joomla40/en/search?q=something

avatar infograf768
infograf768 - comment - 17 Dec 2020

I have tested this item ✅ successfully on cc9e520

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31688.

avatar infograf768 infograf768 - test_item - 17 Dec 2020 - Tested successfully
avatar toivo
toivo - comment - 17 Dec 2020

I have tested this item ✅ successfully on cc9e520

Tested successfully in Beta6-dev of 17 December.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31688.

avatar toivo toivo - test_item - 17 Dec 2020 - Tested successfully
avatar infograf768 infograf768 - change - 17 Dec 2020
Status Pending ⇒ Ready to Commit
avatar infograf768
infograf768 - comment - 17 Dec 2020

rtc

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31688.

avatar wilsonge wilsonge - change - 18 Dec 2020
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2020-12-18 03:06:55
Closed_By ⇒ wilsonge
Labels Added: ? ?
avatar wilsonge wilsonge - close - 18 Dec 2020
avatar wilsonge wilsonge - merge - 18 Dec 2020
avatar wilsonge
wilsonge - comment - 18 Dec 2020

Thanks!

avatar wilsonge
wilsonge - comment - 18 Dec 2020

Thanks!

Add a Comment

Login with GitHub to post a comment