? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
17 Dec 2020

error from aef4d2f

code review

avatar brianteeman brianteeman - open - 17 Dec 2020
avatar brianteeman brianteeman - change - 17 Dec 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Dec 2020
Category Layout
avatar alikon alikon - test_item - 17 Dec 2020 - Tested successfully
avatar alikon
alikon - comment - 17 Dec 2020

I have tested this item successfully on c563b4f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31686.

avatar richard67 richard67 - test_item - 17 Dec 2020 - Tested successfully
avatar richard67
richard67 - comment - 17 Dec 2020

I have tested this item successfully on c563b4f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31686.

avatar richard67 richard67 - change - 17 Dec 2020
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 17 Dec 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31686.

avatar richard67 richard67 - change - 17 Dec 2020
Labels Added: ? ?
avatar infograf768
infograf768 - comment - 17 Dec 2020

There are other errors in this file related to last merge. Usage of strtotime() is wrong as stated in maintainers chat.

@wilsonge Are you going to debug your last merge and correct all issues or shall we correct one at a time?

avatar wilsonge wilsonge - change - 17 Dec 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-12-17 15:13:30
Closed_By wilsonge
Labels
avatar wilsonge wilsonge - close - 17 Dec 2020
avatar wilsonge wilsonge - merge - 17 Dec 2020
avatar wilsonge
wilsonge - comment - 17 Dec 2020

Thanks

@wilsonge Are you going to debug your last merge and correct all issues or shall we correct one at a time?

I'll do what I can but I'll still probably miss some parts. i'm focussing on the downloads site translation pack stuff - so if you have time feel free to submit something

avatar brianteeman
brianteeman - comment - 17 Dec 2020

Please stop bikeshedding

thanks for merging

avatar infograf768
infograf768 - comment - 17 Dec 2020

Please stop bikeshedding

I had a good reason to ask George about that. So, please cool down.

#31689

Add a Comment

Login with GitHub to post a comment