Feeling Lucky
?
NPM Resource Changed
?
?
[#31667] - [4.0] Cassiopeia: Add height auto to images to maintain aspect ratio
- Fixed in Code Base
- 17 Dec 2020
- Medium
- Build: 4.0-dev
- # 31667
- Diff
- drmenzelit:4.0-dev-img-format
- Pending continuous-integration/drone/pr Build is running Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #31647 .
Summary of Changes
Added height: auto to img to maintain aspect ratio when width 100%
Testing Instructions
Create an article with a full image in format 16:9 (e.g. 1280 x 720px), set Image Class to float-none.
Install this PR and run "npm run build:css"
Actual result BEFORE applying this Pull Request
The image will have a width of 100%, but the height stay at 720px, so the aspect ratio is distorted.
Expected result AFTER applying this Pull Request
The image is 100% wide and the height scale proportionally.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Templates (site) NPM Change |
| Labels |
Added:
?
NPM Resource Changed
?
|
||
chmst
- comment
- 16 Dec 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31667.
gostn
- comment
- 17 Dec 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31667.
| Status | Pending | ⇒ | Ready to Commit |
infograf768
- comment
- 17 Dec 2020
rtc
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31667.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-12-17 15:17:57 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
wilsonge
- comment
- 17 Dec 2020
Thanks!
@drmenzelit The phpcs failure in Drone is not related to your PR, it comes from the 4.0-dev branch having had code style errors when you had created your branch based on it. But if you want to get rid of the Drone failure, update your branch to latest 4.0-dev, where the errors meanwhile have been corrected.