[#31666] - Use Factory::, not JFactory
- Fixed in Code Base
- 15 Dec 2020
- Medium
- Build: 4.0-dev
- # 31666
- Diff
- ReLater:patch-1
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
- Whilst fiddling with com_joomlaupdate > Upload & Update in a J4 nightly of today I saw several times error like
Class 'Joomla\Component\Joomlaupdate\Administrator\Controller\JFactory' not found
thrown by
JROOT/administrator/components/com_joomlaupdate/src/Controller/UpdateController.php:122
Reason is commit af5b100#diff-b4783c09040c64562973e4fa903f3c5e844a7a4fc6aa9c0a18fcb4765eae673f
Testing
- Code review. It's obvious.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_joomlaupdate |
@ReLater The phpcs failure in Drone is not related to your PR, it comes from the 4.0-dev branch having had code style errors when you had created your branch based on it. But if you want to get rid of the drone failure, update your branch to latest 4.0-dev, where the errors meanwhile have been corrected.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31666.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31666.
| Labels |
Added:
?
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-12-15 16:20:12 |
| Closed_By | ⇒ | wilsonge | |
| Labels | |||
Thanks!
I have tested this item✅ successfully on 1e988dd
Code review.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31666.