?
avatar brianteeman
brianteeman
12 Dec 2020

image

  1. What is the purpose of the URL column?
  2. Would it be better to say enabled/disabled instead of published/unpublished?

@zero-24

avatar brianteeman brianteeman - open - 12 Dec 2020
avatar joomla-cms-bot joomla-cms-bot - change - 12 Dec 2020
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 12 Dec 2020
avatar zero-24
zero-24 - comment - 12 Dec 2020

What is the purpose of the URL column?

The original site what that report is comming from.

Would it be better to say enabled/disabled instead of published/unpublished?

Whatever is best. Enabled / Disabled should work too IIRC published/unpublished is just the default :)

avatar brianteeman
brianteeman - comment - 12 Dec 2020

What is the purpose of the URL column?

The original site what that report is comming from.

Wouldn't that be the domain then and not the URL ?

Would it be better to say enabled/disabled instead of published/unpublished?

Whatever is best. Enabled / Disabled should work too IIRC published/unpublished is just the default :)

For me it is like plugins and should be enabled etc. I will prepare a PR for that

avatar zero-24
zero-24 - comment - 12 Dec 2020

Wouldn't that be the domain then and not the URL ?

One site only has (usually) only one domain right? When the report comes from example.org/joomla/10-joomla than this is the URL? Or I'm missing something?

avatar brianteeman
brianteeman - comment - 12 Dec 2020

So then there is a bug as all my entries in the column are identical as shown in the screenshot

avatar brianteeman
brianteeman - comment - 12 Dec 2020

PR for the enabled instead of publish #31643

avatar zero-24
zero-24 - comment - 15 Dec 2020

So then there is a bug as all my entries in the column are identical as shown in the screenshot

Well do you have other sub pages where specific stuff is loaded that is not loaded on the main page? For example a youtube page?

avatar zero-24
zero-24 - comment - 15 Dec 2020

PR for the enabled instead of publish #31643

Thanks.

avatar brianteeman
brianteeman - comment - 15 Dec 2020

The site is installed at http://localhost/joomla-cms

Below is the results after having detect mode on for site and admin and then visiting multiple pages on both. As you can see they all have the identical data in the URI column - I was expecting the full link to the page so that I am able to see what is causing the report.

image

avatar zero-24
zero-24 - comment - 15 Dec 2020

I was expecting the full link to the page so that I am able to see what is causing the report.

Yes that is or better was the intended behavior seems to be a bug to me. Also seems that I actually implemented that issue in there.

In the end that line should be something like:

$report->blocked_uri = $parsedBlockedUri['scheme'] . '://' . $parsedBlockedUri['host'] . '/' .  $parsedBlockedUri['path'] . '/' . $parsedBlockedUri['query'];

Maybe we even better throw that into the Uri class?

avatar richard67
richard67 - comment - 18 Dec 2020

Should we move this to discussions?

avatar brianteeman
brianteeman - comment - 18 Dec 2020

No - its a bug

avatar rdeutz rdeutz - change - 18 Dec 2020
Status New Closed
Closed_Date 0000-00-00 00:00:00 2020-12-18 10:33:16
Closed_By rdeutz
avatar rdeutz rdeutz - close - 18 Dec 2020

Add a Comment

Login with GitHub to post a comment