[#31640] - [4.0] newsflash string
- Fixed in Code Base
- 19 Dec 2020
- Medium
- Build: 4.0-dev
- # 31640
- Diff
- brianteeman:mod_news
User tests: Successful: Unsuccessful:
Removes an unused string
code review
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Language & Strings |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31640.
Not sure about this one
I guess we should OR add back the desc in the xml OR modify MOD_ARTICLES_NEWS_TITLE_HEADING to specify that it concerns the articles titles. The fact that it follows the Article Title and Linked titles is not enough imho.
Context is everything. You wouldnt even have questioned it if I wasnt removing an unused string
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31640.
| Labels |
Added:
?
?
?
|
||
I can confirm the string isn't used anywhere, and the PR has 2 good tests, so I've set it RTC. If it needs to make the meaning of the field more clear, I suggest to make a new PR e.g. for changing the title.
I have no idea why we delete all descriptions in j4 (because there are better ways to show them) but it is what it is.
Thanks for the cleanup
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-12-19 11:14:25 |
| Closed_By | ⇒ | HLeithner | |
| Labels | |||
I have no idea why we delete all descriptions in j4 (because there are better ways to show them) but it is what it is.
Exactly my feeling, I couldn't have expressed it better.
I have tested this item✅ successfully on 3e58290
Tested successfully in Beta6-dev of 13 December.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31640.