If I understand you package right it simply uses zlib, so we could simply add the lines adding the compression to our build.js? I mean at the moment your script get loaded 3 times from github (maybe cached) but looks like a waste of resources.

Or I'm wrong?

your script get loaded 3 times from github (maybe cached) but looks like a waste of resources.

You could combine the 3 commands to 1. Also since this is done with npx there is no real dependency added (mind that the command is only executed by the release leader, it's a one off execution just before the release of a package)
But yes you could fork the code in the project if you like. (having it as a node package is better imo as 3rd PD can use it as well for their own packages ? )

I’m down - although is there a reason not to have you package as a dev dependency? Just so it’s version locked with everything else

although is there a reason not to have you package as a dev dependency

The idea is to reduce the dependencies that need to be installed (both for CI and local development). Maybe another approach is to create a repo for the npm tools and fork the code there and also transfer the rest of the build tools there as well (yeah I know breaking things to different repos makes it more difficult to maintain but then again those tools should be available to all the 3rd PD, right now this is true only through the 4.0-dev repo). Hard for me to justify what fits better the project but I guess having one line npm commands for any dev should be handy

Unable to test as the command npm run gzip does nothing on my install

@brianteeman interesting, this was already tested on windows, can you try runningcd media and then npx --no-install github:dgrammatiko/compress ? do you get any message? Were any .gz files created?

`C:\htdocs\joomla-cms>npm run gzip 

> joomla@4.0.0 gzip C:\htdocs\joomla-cms
> node -e 'require("./build/build-modules-js/gzip-assets.es6.js").gzipFiles()'

npx --no-install github:dgrammatiko/compress` works perfectly

`

I see, somehow you're executing the old command > node -e 'require("./build/build-modules-js/gzip-assets.es6.js").gzipFiles()', this was before the changes in this PR. I guess it has to do with the conflict?

Yes I am trying to do the first part of the test instructions before applying the pr

Sorry that wasn't clear

Yes I am trying to do the first part of the test instructions before applying the pr

Maybe my instructions are bad, you need to clone and check out the 4.0-dev repo for the first step

thats what I am using - the clone that I do all my dev on

Just to confirm I did a completely new clone and the output of npm run gzip is exactly the same as before

node -e 'require("./build/build-modules-js/gzip-assets.es6.js").gzipFiles()

This probably won't run on windows, can you change ./build/build-modules-js/gzip-assets.es6.js to C:\htdocs\joomla-cms\build\build-modules-js\gzip-assets.es6.js

I could if I could find the file to change :(

It's the package.json but you should be able to run the command directly in the terminal:
node -e 'require("C:\htdocs\joomla-cms\build\build-modules-js\gzip-assets.es6.js").gzipFiles()'

I had already tried that but just double double checked
no change

Maybe its me, maybe its windows. Perhaps another windows user can confirm

found the bug
changing the code in package.json from
"gzip": "node -e 'require(\"./build/build-modules-js/gzip-assets.es6.js\").gzipFiles()'",

to

"gzip": "node -e require('./build/build-modules-js/gzip-assets.es6.js').gzipFiles()",

note the change from "\ to ' and the removal of the ' around require