[#31621] - [4.0] Converting additional mails to mail templates
- Fixed in Code Base
- 7 Jan 2021
- Medium
- Build: 4.0-dev
- # 31621
- Diff
- Hackwar:mailtemplates
User tests: Successful: Unsuccessful:
Pull Request for Issue #29215.
Summary of Changes
This converts the mails of the actionlogs component, the privacy component and the privacy consent plugin to the mail template system.
- Notification mail from com_actionlogs (administrator\components\com_actionlogs\src\Model\ActionlogModel.php line 174)
- com_messages notification (administrator\components\com_messages\src\Model\MessageModel.php line 435)
- com_privacy send export to user (administrator\components\com_privacy\src\Model\ExportModel.php line 240)
- com_privacy notification about a new request (administrator\components\com_privacy\src\Model\RequestModel.php line 362)
- com_privacy creating a new request (components\com_privacy\src\Model\RequestModel.php line 188/190 ATTENTION!! HERE IS A BUG! The mail is send twice!)
- reminder of expiring privacy consent (plugins\system\privacyconsent\privacyconsent.php line 604)
- User registration (components\com_users\src\Model\RegistrationModel.php line 198, 254, 650, 711)
The mentioned bug has also been fixed.
Testing Instructions
You have to trigger the feature to send these mails to test this.
- Go to your user profile in the backend and enable to receive actionlog updates. You should get a mail when you login.
- Create a request for export or removal in the frontend privacy component to trigger the frontend mails.
- Create a request for export or removal in the backend privacy component to trigger the backend mails.
- Send the export of data in the backend via mail to trigger that one...
- Enable renewable consents, give consent and then edit it in the database to be close to expiration. That should trigger that last mail.
- Register users with all the different settings we have.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration SQL com_admin Postgresql Language & Strings Front End Plugins |
You've removed the instructions to translators
You can use the following merge codes for all COM_PRIVACY_EMAIL strings:
But shouldnt that be replaced with a note to translators about the placeholders in the new strings?
| Labels |
Added:
?
?
|
||
| Category | Administration SQL com_admin Postgresql Language & Strings Front End Plugins | ⇒ | Administration SQL com_admin Postgresql Language & Strings Front End Installation Plugins |
@brianteeman I deleted the file. Regarding the placeholders: Since those aren't fixed anymore and can be extended at will, I don't think the notes are helpfull enough to keep them. I understand your point, but I think that will create more confusion than be helpfull. If you disagree hard on that, I can put those back in, but I would prefer to leave that out.
@richard67 Fixed.
| Category | Administration SQL com_admin Postgresql Language & Strings Front End Plugins Installation | ⇒ | Administration SQL com_admin Postgresql Language & Strings Front End com_users Installation Plugins |
| Category | Administration SQL com_admin Postgresql Language & Strings Front End Plugins Installation com_users | ⇒ | Administration SQL com_admin Postgresql com_messages Language & Strings Front End com_users Installation Plugins |
Ok, now all mails have been converted to templates. I don't want to have to do that again...
I encountered one issue: When you are in the mail template component, you can filter by extension. When you do that, you get only a reduced number of strings translated in that list, since we only load the extension translation files for which we currently have templates displayed. I'm not yet sure where to put code to load those files every time...
BTW: That makes 25 mail templates so far in the system.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-01-07 02:29:15 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
I'm merging this without tests so it's in the beta for this evening
Dont you need to delete this file if it is no longer being used ?
administrator\components\com_actionlogs\layouts\logstable.php