? ? ? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
9 Dec 2020

Pull Request for Issue #31598

Summary of Changes

As title says. Tested in php 3.7.9 and php 7.4.2

Testing Instructions

Install
pkg_maximenuckparams_4.1.1.zip

Then go to Update Manager, select the file and click Update

Actual result BEFORE applying this Pull Request

many php warnings in php logs (see #31598) in php 7.4+

message displays Error updating COM_INSTALLER_TYPE_TYPE_.

Expected result AFTER applying this Pull Request

No more php warnings.
New message (specific to this extension update temp file):

Screen Shot 2020-12-09 at 11 49 40

Documentation Changes Required

None

@jsubri @HLeithner

avatar infograf768 infograf768 - open - 9 Dec 2020
avatar infograf768 infograf768 - change - 9 Dec 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 Dec 2020
Category Administration com_installer Language & Strings
avatar infograf768 infograf768 - change - 9 Dec 2020
The description was changed
avatar infograf768 infograf768 - edited - 9 Dec 2020
avatar jsubri
jsubri - comment - 9 Dec 2020

@infograf768 thank you.

No more PHP warnings, all good for me tested on 3.9.23 with
Database Version 5.5.5-10.4.17-MariaDB
Database Collation utf8mb4_general_ci
Database Connection Collation utf8mb4_general_ci
PHP Version 8.0.0
screen shot 2020-12-09 at 19 41 24


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31620.
avatar gostn
gostn - comment - 10 Dec 2020

@jsubri please mark your test as successfully at https://issues.joomla.org/tracker/joomla-cms/31620

avatar gostn gostn - test_item - 10 Dec 2020 - Tested successfully
avatar gostn
gostn - comment - 10 Dec 2020

I have tested this item successfully on 008fff9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31620.

avatar infograf768 infograf768 - alter_testresult - 10 Dec 2020 - jsubri: Tested successfully
avatar infograf768 infograf768 - change - 10 Dec 2020
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 10 Dec 2020

Added @jsubri as successful test.

RTC. Thanks for testing.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31620.

avatar HLeithner HLeithner - change - 10 Dec 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-12-10 07:37:38
Closed_By HLeithner
Labels Added: ? ? ?
avatar HLeithner
HLeithner - comment - 10 Dec 2020

Thanks

avatar PhilETaylor
PhilETaylor - comment - 18 Dec 2020

The filename index.php_option_com_dms_task_doc_download_id_129_updater_true is a system generated file name, its a transient temp file and should be deleted before the error is rendered to the screen.

The file actually is a HTML file, and is actually left in the tmp folder incorrectly.

Its completely redundant in the error message.

I'll fork to a new issue.

Add a Comment

Login with GitHub to post a comment