Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#31609] - [4.0] add aria-label / aria-labelledby to module rendering

? ?
avatar brianteeman
brianteeman
7 Dec 2020

@hans2103 introduced code with #29886 which correctly adds aria values to the module if it is using a landmark. However it also adds the value if it is a div and it has no effect here at all as assistive tech can not see it

Reference https://developer.paciellogroup.com/blog/2017/07/short-note-on-aria-label-aria-labelledby-and-aria-describedby/

Summary
If you use aria-label, aria-labelledby, or aria-describedby with any other elements (like div, span, p, blockquote, or strong etc.), they generally won’t work across all browser/assistive technology combinations.

Confirmed that this is still valid advice with the author https://twitter.com/LeonieWatson/status/1335905663113900033

avatar brianteeman brianteeman - open - 7 Dec 2020
avatar joomla-cms-bot joomla-cms-bot - change - 7 Dec 2020
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 7 Dec 2020
avatar chmst chmst - edited - 7 Dec 2020
avatar chmst chmst - change - 7 Dec 2020
Category ⇒ Accessibility
avatar chmst chmst - change - 18 Dec 2020
Labels Added: ?
avatar chmst chmst - labeled - 18 Dec 2020
avatar brianteeman brianteeman - change - 3 Jan 2021
Status New ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2021-01-03 00:33:30
Closed_By ⇒ brianteeman
Labels Added: ?
Removed: ?
avatar brianteeman
brianteeman - comment - 3 Jan 2021

Closed as we have two pr to resolve this

avatar brianteeman brianteeman - close - 3 Jan 2021

Add a Comment

Login with GitHub to post a comment