[#31608] - [4.0] Admin module checkout id [a11y]
- Fixed in Code Base
- 7 Dec 2020
- Medium
- Build: 4.0-dev
- # 31608
- Diff
- brianteeman:admin_module
User tests: Successful: Unsuccessful:
Every id on a page must be unique. Before this PR the id of the checked out icon in the admin modules Article Latest and Article Popular could be identical as it only used the number of the item in the list as the id. This PR additionally adds the name of the module and module id to ensure that the checked out id is unique.
To test you will need to have some checked out articles and then you can view the source and see the arialabelledby id
Before the pr it will look like
aria-labelledby="cbcheckin3-desc
After the pr it will look like
aria-labelledby="cbcheckinPopularArticles3-desc
cc @carcam
Votes
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Administration |
I have not tested this item.
Is the patch on FrontEnd?
I try it
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31608.
it is only on the two admin modules that support checkin
I have tested this item
Dne
The variation is on backEnd side!
Befaure the apply PR the attr aria-labelledby there is no. I've a test on module page.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31608.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31608.
| Labels |
Added:
?
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-12-07 15:50:20 |
| Closed_By | ⇒ | chmst | |
| Labels | |||
Thanks!
I have tested this item✅ successfully on 7672c4a
Tested successfully in Beta6-dev of 7 December.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31608.