Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#31567] - [4.0] Subform fixes

NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar Denitz
Denitz
3 Dec 2020

Summary of Changes

Changes in repeatable-table subform layout:

  1. Use correct .table-responsive wrapper.
  2. Use a unique ID for the subform table.
  3. Don't display the field description because it's already displayed as a tooltip in the column header.
  4. Remove the implicit style of width:45% for th.

Common changes:

  1. Don't pass $subForm param by reference in SubformField::loadSubFormData(Form $subForm) because it's an object.
  2. Fix phpdoc in SubformField::setup() for undefined class SimpleXMLElement
  3. Propagate originating field ID into subform layouts via $fieldId
  4. Make SubformField::loadSubFormData protected for possible override.
  5. Fixed actually displayed .control-label.sr-only which still consumed 240px width and broke the table-responsive behavior with screen horizontal scrolling remained.

Testing Instructions

Show multiple subform fields on the same page, use wide forms to require responsive scroller.

Actual result BEFORE applying this Pull Request

Duplicate table IDs, field descriptions below each field, the table is not responsive.

Expected result AFTER applying this Pull Request

Unique table IDs, field descriptions are hidden, the table is responsive.

Documentation Changes Required

No.

avatar Denitz Denitz - open - 3 Dec 2020
avatar Denitz Denitz - change - 3 Dec 2020
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 Dec 2020
Category ⇒ Layout Libraries
avatar Denitz Denitz - change - 4 Dec 2020
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 4 Dec 2020
Category Layout Libraries ⇒ Administration Templates (admin) NPM Change Layout Libraries
avatar Denitz Denitz - change - 4 Dec 2020
The description was changed
avatar Denitz Denitz - edited - 4 Dec 2020
avatar Denitz Denitz - change - 4 Dec 2020
Labels Added: NPM Resource Changed
avatar Denitz Denitz - change - 16 Feb 2021
Labels Added: Conflicting Files
avatar Denitz
Denitz - comment - 16 Feb 2021

@Quy no conflicts now

avatar Quy
Quy - comment - 25 Mar 2021

Please fix conflicts.

d5b3e2b 26 Mar 2021 avatar Denitz fix
avatar Denitz Denitz - change - 29 Mar 2021
Labels Removed: Conflicting Files
avatar RickR2H RickR2H - test_item - 24 Apr 2021 - Tested successfully
avatar RickR2H
RickR2H - comment - 24 Apr 2021

I have tested this item ✅ successfully on 2affe23

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31567.

avatar Quy Quy - test_item - 10 Jun 2021 - Tested successfully
avatar Quy
Quy - comment - 10 Jun 2021

I have tested this item ✅ successfully on 2affe23

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31567.

avatar Quy Quy - change - 10 Jun 2021
Status Pending ⇒ Ready to Commit
avatar Quy
Quy - comment - 10 Jun 2021

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31567.

avatar richard67 richard67 - change - 12 Jun 2021
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2021-06-12 13:01:23
Closed_By ⇒ richard67
Labels Added: ?
avatar richard67 richard67 - close - 12 Jun 2021
avatar richard67 richard67 - merge - 12 Jun 2021
avatar richard67
richard67 - comment - 12 Jun 2021

Thanks!

Add a Comment

Login with GitHub to post a comment