Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#31566] - Use &quote; instead of \"

? ? Pending

User tests: Successful: Unsuccessful:

avatar chmst
chmst
3 Dec 2020

Pull Request for Issue #31564 .

Summary of Changes

Changed "%s" to &quote;%s&quote for an url.

Testing Instructions

see #31564

Unfortunately I cannot test with php 8.

avatar chmst chmst - open - 3 Dec 2020
avatar chmst chmst - change - 3 Dec 2020
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 Dec 2020
Category ⇒ Administration Language & Strings
avatar toivo toivo - test_item - 3 Dec 2020 - Tested successfully
avatar toivo
toivo - comment - 3 Dec 2020

I have tested this item ✅ successfully on 9a3811b

Tested successfully in Beta6-dev of 3 December using PHP 7.4.13.

Installing sample data in PHP 8.0.0 fails with the message "There is an error in sample data plugin. Response in invalid".

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31566.

avatar toivo
toivo - comment - 3 Dec 2020

It would be too early to test in PHP 8 because apparently not all the PHP 8 fixes from 3.9.23 have been implemented in Joomla 4. This info is from yesterday.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31566.

avatar kk9 kk9 - test_item - 5 Dec 2020 - Tested successfully
avatar kk9
kk9 - comment - 5 Dec 2020

I have tested this item ✅ successfully on 9a3811b

Tested on 7.3.21

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31566.

avatar paritshivani paritshivani - test_item - 5 Dec 2020 - Tested successfully
avatar paritshivani
paritshivani - comment - 5 Dec 2020

I have tested this item ✅ successfully on 9a3811b

Tested successfully.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31566.

avatar frostmakk frostmakk - test_item - 5 Dec 2020 - Tested unsuccessfully
avatar frostmakk
frostmakk - comment - 5 Dec 2020

I have tested this item ? unsuccessfully on 9a3811b

The issue this PR is supposed to fix is installing sample data when running PHP 8.0
It does not fix the issue.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31566.

avatar frostmakk
frostmakk - comment - 5 Dec 2020

From debug:
CRITICAL ::1 error Uncaught Throwable of type ValueError thrown with message "Missing format specifier at end of string". Stack trace: #0 D:\virtualhosts\new40\libraries\vendor\wamania\php-stemmer\src\StemmerFactory.php(52)

If line 52 in StemmerFactory.php is changed from:
throw new NotFoundException(sprintf('Stemmer not found for %', $code));
to:
throw new NotFoundException(sprintf('Stemmer not found for %d', $code));
the sample data installation works.

EDIT: %s would probably be more correct.

avatar chmst
chmst - comment - 6 Dec 2020

Closing this, it dies not resolve the issue

avatar chmst chmst - change - 6 Dec 2020
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2020-12-06 22:54:07
Closed_By ⇒ chmst
Labels Added: ? ?
avatar chmst chmst - close - 6 Dec 2020

Add a Comment

Login with GitHub to post a comment