[#31555] - [4.0-dev] Cassiopeia set font-size-root to 1em
- Fixed in Code Base
- 2 Dec 2020
- Medium
- Build: 4.0-dev
- # 31555
- Diff
- hans2103:patch-1
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
This PR will change the $font-size-root to 1em.
Increasing font-size with increasing viewport width is too early for us. :-)
Testing Instructions
- Joomla 4
npm run build:css- see frontend ... increase view port and see that font-size grows
- apply path
npm run build:css- see frontend. ... increase viewport and see that font-size does not grow anymore
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Templates (site) NPM Change |
| Title |
|
||||||
To clarify my comment and the discussion we had in glip chat:
the issue with Cassiopea font size concerns mainly larger monitors where the font size has an enormous impact on scrolling.
Even this new size is a bit too big for me on both
iMac: Display Type: Built-In Retina LCD
Resolution: 4096 x 2304 Retina
and
SMB2440MH:
Resolution: 1920 x 1080 @ 60 Hz
Discussion opened:
The issue @brianteeman is referring to is for Atum, backend template, not for Cassiopeia, frontend template.
With the build of Cassiopeia the font-size-root was set early. All font-sizes, paddings and margins are based on that.
We've tried to stay away from Bootstrap as much as possible.
I have tested this item
It is generally agreed upon that 16px (1em) for body text is a good starting point for AA. This PR has no visible impact on the font sizes on my Laptop and monitor, so it is ok for me.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31555.
@hans2103 the issue is exactly the same as is the solution. Both templates are bootstrap 4 based and currently both are defining all the font sizes incorrectly. Avoiding well defined bootstrap markup by overriding it is not the cleverest thing in the world. Remember
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31555.
| Labels |
Added:
?
?
NPM Resource Changed
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-12-02 16:08:46 |
| Closed_By | ⇒ | drmenzelit | |
| Labels | |||
Thanks!
This should not have been merged - it is wrong
The PR set the font-size-root back to 1rem as Bootstrap do.
@brianteeman the only thing wrong with this pr is that it's declaring something that is predeclared in the browser.
@hans2103 the issue is exactly the same as is the solution. Both templates are bootstrap 4 based and currently both are defining all the font sizes incorrectly. Avoiding well defined bootstrap markup by overriding it is not the cleverest thing in the world. Remember
you stress how anti-bootstrap it is, when infact it is EXACTLY what bootstrap does which is why imo it's not needed.
This is straight out of BS4!
$font-size-base: 1rem !default; // Assumes the browser default, typically `16px`
$font-size-lg: $font-size-base * 1.25 !default;
$font-size-sm: $font-size-base * .875 !default;
I have tested this item✅ successfully on 041c21c
better than before.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31555.