[#31554] - [J!3.9] Update of joomla-framework/image #31552
- Fixed in Code Base
- 14 Dec 2020
- Medium
- Build: staging
- # 31554
- Diff
- xillibit:J39_PR1
User tests: Successful: Unsuccessful:
Pull Request for Issue #31552.
Summary of Changes
Changes the checks for the Php 8.0 compatibility after the calls of imagecreatefromgif, imagecreatefromjpeg and imagecreatefrompng when the image is loaded because it doesn't return a ressource in Php 8.0 but an object
Testing Instructions
Use an extension which use the Joomla\Image class
Actual result BEFORE applying this Pull Request
Exception : Unable to process JPG image. in C:\Users\xillibit\git\joomla-cms-39\libraries\vendor\joomla\image\src\Image.php on line 143
Expected result AFTER applying this Pull Request
No exception
Documentation Changes Required
No
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | External Library Libraries Composer Change |
| Labels |
Added:
?
?
|
||
Please don't edit an external dependency. Fix it in the framework package and then update the composer.json.
PR done on joomla-framework : joomla-framework/image#23, but it's has no sense because the image package in framework will be removed and replaced by Joomla\CMS\Image : #22817 (comment). It's already the case in J!4.0
Just released joomla/image-1.5.1 as a PHP8 compatibility release.
I'am trying to update the joomla\image package in joomla, i have changed in composer.json the line of joomla\image like that :
"joomla/image": "^1.5.1",
then when i do an composer update joomla\image it fails :
Failed to clone the git@github.com:joomla-backports/lessphp.git repository, try running in interactive mode so that you can enter your GitHub credentials
joomla/image is not a Composer dependency in the CMS; it is located in libraries/src/, not in libraries/vendor/.
Thus the changes made in the Framework must be ported to the CMS manually.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31554.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31554.
RTC
All the lines are changed because the files had a wrong encoding
All the lines are changed because the file had a wrong encoding
In this PR, in the CMS or in the Framework?
In this PR, in the CMS or in the Framework?
In this PR
@HLeithner : i have updated the PR so you can see the changes
Thanks
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-12-14 19:23:06 |
| Closed_By | ⇒ | HLeithner |
Composer changes are missing...
If this has been reverted please can it be removed from the milestone for 3.9.24RC ? as it shows up as something changed in 3.9.24RC for testing.
@PhilETaylor the revert was not in the milestone (my fault) but the composer update has actually be done in #31663
I have tested this item✅ successfully on 32055da
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31554.