PR-4.0-dev ?

Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
27 Nov 2020

Pull Request for Issue #31508 .

Summary of Changes

Remove the hardcoded favicon from the templates manifests (atum + cassiopeia)

Testing Instructions

Try to copy a template

Actual result BEFORE applying this Pull Request

Missing favicon

Expected result AFTER applying this Pull Request

All good, you successfully cloned the template

Documentation Changes Required

A bit of documentation about the favicons:

  • The actual files are in media/system/images
  • Can be overridden by copying these files to templates\templateName\images\favicon**.(svg|ico)
  • Any updates will not affect your overrides (a popular question in the forum)

Things to note about the svg files:

  • the contents of the joomla-favicon can be replaced with any valid svg (the viewBox can be anything user defined)
  • the contents of the joomla-favicon-pinned can be replaced with any valid svg BUT the viewBox needs to remain viewBox="0 0 16 16"
  • The classic favicon.ico can be either 16x16 or 32x32
avatar dgrammatiko dgrammatiko - open - 27 Nov 2020
avatar dgrammatiko dgrammatiko - change - 27 Nov 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 27 Nov 2020
Category Administration Templates (admin) Repository NPM Change Front End Templates (site)
avatar dgrammatiko dgrammatiko - change - 27 Nov 2020
The description was changed
avatar dgrammatiko dgrammatiko - edited - 27 Nov 2020
avatar dgrammatiko dgrammatiko - change - 27 Nov 2020
The description was changed
avatar dgrammatiko dgrammatiko - edited - 27 Nov 2020
avatar dgrammatiko dgrammatiko - change - 27 Nov 2020
The description was changed
avatar dgrammatiko dgrammatiko - edited - 27 Nov 2020
avatar ceford ceford - test_item - 28 Nov 2020 - Tested successfully
avatar ceford
ceford - comment - 28 Nov 2020

I have tested this item successfully on 7bbf37f

Applied patch and copied both templates successfully. Reviewed code too. Thanks for attending to this so promptly.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31512.

avatar gostn gostn - test_item - 28 Nov 2020 - Tested successfully
avatar gostn
gostn - comment - 28 Nov 2020

I have tested this item successfully on 7bbf37f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31512.

avatar alikon alikon - change - 28 Nov 2020
Status Pending Ready to Commit
avatar alikon
alikon - comment - 28 Nov 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31512.

avatar richard67
richard67 - comment - 28 Nov 2020

System test failure in Drone seems not to be related to this PR. It seems to be a problem with our testing environment.

avatar laoneo laoneo - change - 30 Nov 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-11-30 14:47:01
Closed_By laoneo
Labels Added: PR-4.0-dev ?
avatar laoneo laoneo - close - 30 Nov 2020
avatar laoneo laoneo - merge - 30 Nov 2020
avatar laoneo
laoneo - comment - 30 Nov 2020

Thanks!

Add a Comment

Login with GitHub to post a comment