Feeling Lucky
?
?
[#31512] - [4.0] Favicons fixes
- Fixed in Code Base
- 30 Nov 2020
- Medium
- Build: 4.0-dev
- # 31512
- Diff
- dgrammatiko:4.0-dev_favicons
User tests: Successful: Unsuccessful:
Pull Request for Issue #31508 .
Summary of Changes
Remove the hardcoded favicon from the templates manifests (atum + cassiopeia)
Testing Instructions
Try to copy a template
Actual result BEFORE applying this Pull Request
Missing favicon
Expected result AFTER applying this Pull Request
All good, you successfully cloned the template
Documentation Changes Required
A bit of documentation about the favicons:
- The actual files are in
media/system/images - Can be overridden by copying these files to
templates\templateName\images\favicon**.(svg|ico) - Any updates will not affect your overrides (a popular question in the forum)
Things to note about the svg files:
- the contents of the
joomla-faviconcan be replaced with any valid svg (the viewBox can be anything user defined) - the contents of the
joomla-favicon-pinnedcan be replaced with any valid svg BUT the viewBox needs to remainviewBox="0 0 16 16" - The classic favicon.ico can be either 16x16 or 32x32
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) Repository NPM Change Front End Templates (site) |
gostn
- comment
- 28 Nov 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31512.
| Status | Pending | ⇒ | Ready to Commit |
alikon
- comment
- 28 Nov 2020
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31512.
richard67
- comment
- 28 Nov 2020
System test failure in Drone seems not to be related to this PR. It seems to be a problem with our testing environment.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-11-30 14:47:01 |
| Closed_By | ⇒ | laoneo | |
| Labels |
Added:
?
?
|
||
laoneo
- comment
- 30 Nov 2020
Thanks!
I have tested this item✅ successfully on 7bbf37f
Applied patch and copied both templates successfully. Reviewed code too. Thanks for attending to this so promptly.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31512.