PR-4.0-dev ?

Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
27 Nov 2020

Pull Request for Issue #31509 .

Summary of Changes

Fixing bad URL (front end links replace & with &, my bad never tested that case

Testing Instructions

Try to add an image to a menuItem or to the offline page.

Expected == Actual result

The image is selected and the image name is stored in the parameter images.

Documentation Changes Required

@wilsonge just FWIW the new URL with the extra 2 params will always fail for code like: <?php if ($app->get('offline_image') && file_exists($app->get('offline_image'))) : ?> (interpreting the URL as a file path). I think this is something that needs to be communicated. (it's not that bad, removing the file_exists, will get you back to 100% compatibility, eg a URL with the extra params that works fine but a better and safer way out is to use the HTMLHelper::image as the tag will be inserted only if the file exists).

avatar dgrammatiko dgrammatiko - open - 27 Nov 2020
avatar dgrammatiko dgrammatiko - change - 27 Nov 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 27 Nov 2020
Category Libraries
avatar dgrammatiko dgrammatiko - change - 27 Nov 2020
Labels Added: PR-4.0-dev
avatar joomla-cms-bot joomla-cms-bot - change - 27 Nov 2020
Category Libraries Libraries Front End Templates (site)
avatar dgrammatiko dgrammatiko - change - 28 Nov 2020
The description was changed
avatar dgrammatiko dgrammatiko - edited - 28 Nov 2020
avatar chmst chmst - test_item - 28 Nov 2020 - Tested successfully
avatar chmst
chmst - comment - 28 Nov 2020

I have tested this item successfully on af9be28

I have tested successfully with menus, contact, articles and offline page.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31511.
avatar ceford ceford - test_item - 28 Nov 2020 - Tested successfully
avatar ceford
ceford - comment - 28 Nov 2020

I have tested this item successfully on af9be28

Checked both menu and off-line page - image present and correct.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31511.

avatar richard67
richard67 - comment - 28 Nov 2020

System test failure in Drone seems not to be related to this PR. It seems to be a problem with our testing environment.

avatar chmst
chmst - comment - 28 Nov 2020

RTC

avatar chmst chmst - change - 28 Nov 2020
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 28 Nov 2020

@SharkyKZ Why thumbs down? (curious)

avatar dgrammatiko dgrammatiko - change - 28 Nov 2020
Labels Added: ?
avatar laoneo laoneo - change - 30 Nov 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-11-30 15:03:05
Closed_By laoneo
avatar laoneo laoneo - close - 30 Nov 2020
avatar laoneo laoneo - merge - 30 Nov 2020
avatar laoneo
laoneo - comment - 30 Nov 2020

Thanks!

Add a Comment

Login with GitHub to post a comment