User tests: Successful: Unsuccessful:
Pull Request for Issue #31509 .
Fixing bad URL (front end links replace
&, my bad never tested that case
Try to add an image to a menuItem or to the offline page.
The image is selected and the image name is stored in the parameter images.
@wilsonge just FWIW the new URL with the extra 2 params will always fail for code like:
<?php if ($app->get('offline_image') && file_exists($app->get('offline_image'))) : ?> (interpreting the URL as a file path). I think this is something that needs to be communicated. (it's not that bad, removing the
file_exists, will get you back to 100% compatibility, eg a URL with the extra params that works fine but a better and safer way out is to use the
HTMLHelper::image as the tag will be inserted only if the file exists).
|Category||Libraries||⇒||Libraries Front End Templates (site)|
System test failure in Drone seems not to be related to this PR. It seems to be a problem with our testing environment.
|Status||Pending||⇒||Ready to Commit|
|Status||Ready to Commit||⇒||Fixed in Code Base|
|Closed_Date||0000-00-00 00:00:00||⇒||2020-11-30 15:03:05|