No Code Attached Yet
avatar wilsonge
wilsonge
26 Nov 2020

Merging #29524 had tonnes of conflicts with current J4. For now I've dropped the new code in but it's going to need:

  • Removal of jquery'ing
  • Migration of classes from bootstrap 2 to bootstrap 4
  • Review if there needs to be any further cleanup that we've done in J4 extensions
avatar wilsonge wilsonge - open - 26 Nov 2020
avatar joomla-cms-bot joomla-cms-bot - change - 26 Nov 2020
Labels Added: ? ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 26 Nov 2020
avatar wilsonge wilsonge - change - 26 Nov 2020
The description was changed
avatar wilsonge wilsonge - edited - 26 Nov 2020
avatar wilsonge wilsonge - change - 26 Nov 2020
The description was changed
avatar wilsonge wilsonge - edited - 26 Nov 2020
avatar brianteeman
brianteeman - comment - 26 Nov 2020

I cleaned up the codestyle in #31493 so it is at least easy to read for anyone working on the above

avatar brianteeman
brianteeman - comment - 30 Nov 2020

oh - boy - this needs a complete rewrite

avatar wilsonge
wilsonge - comment - 1 Dec 2020

Javascript needs a lot of work for sure. Anything specific from your side that gave that reaction?

avatar wilsonge
wilsonge - comment - 21 Feb 2021

Done some more cleanup. At least some of the stuff is beginning to functionally work again.

avatar joomdonation
joomdonation - comment - 7 Mar 2021

Made PR #32602 to remove jQuery dependency for pre-update check. Do we want to remove jQuery from https://github.com/joomla/joomla-cms/blob/4.0-dev/build/media_source/com_joomlaupdate/js/update.es5.js , too ?

avatar wilsonge
wilsonge - comment - 14 Mar 2021

Ideally yes but don't think that's a release blocker level. Just need to make sure everything works and is styled properly for the preupdate checker. Then can downgrade the rest to a regular issue

avatar wilsonge wilsonge - change - 21 Mar 2021
The description was changed
avatar wilsonge wilsonge - edited - 21 Mar 2021
avatar wilsonge wilsonge - change - 21 Mar 2021
The description was changed
avatar wilsonge wilsonge - edited - 21 Mar 2021
avatar wilsonge
wilsonge - comment - 21 Mar 2021

OK Functionally things seem to work again. I'm leaving the issue open because it probably still needs further code review. But I'm removing the release blocker tag

avatar wilsonge wilsonge - change - 21 Mar 2021
Labels Removed: ?
avatar wilsonge wilsonge - unlabeled - 21 Mar 2021
avatar brianteeman
brianteeman - comment - 21 Mar 2021

and what about the FTP stuff?
Thats part of the update component and there has been nothing proposed for that at all

avatar wilsonge
wilsonge - comment - 21 Mar 2021

What's broken with the FTP stuff? As far as I'm concerned nothing should have changed there between J3.x and 4.x?

avatar brianteeman
brianteeman - comment - 22 Mar 2021

What's broken with the FTP stuff? As far as I'm concerned nothing should have changed there between J3.x and 4.x?

For a start if you select FTP then you dont get prompted for the ftp username and password

avatar joomdonation
joomdonation - comment - 22 Mar 2021

For a start if you select FTP then you dont get prompted for the ftp username and password

PR #32799 should fix that issue.

avatar dgrammatiko
dgrammatiko - comment - 9 Nov 2021

please close

avatar wilsonge wilsonge - change - 14 Jan 2022
Status New Closed
Closed_Date 0000-00-00 00:00:00 2022-01-14 12:27:28
Closed_By wilsonge
Labels Added: No Code Attached Yet
Removed: ?
avatar wilsonge wilsonge - close - 14 Jan 2022

Add a Comment

Login with GitHub to post a comment