Merging #29524 had tonnes of conflicts with current J4. For now I've dropped the new code in but it's going to need:
Labels |
Added:
?
?
|
oh - boy - this needs a complete rewrite
Javascript needs a lot of work for sure. Anything specific from your side that gave that reaction?
Done some more cleanup. At least some of the stuff is beginning to functionally work again.
Made PR #32602 to remove jQuery dependency for pre-update check. Do we want to remove jQuery from https://github.com/joomla/joomla-cms/blob/4.0-dev/build/media_source/com_joomlaupdate/js/update.es5.js , too ?
Ideally yes but don't think that's a release blocker level. Just need to make sure everything works and is styled properly for the preupdate checker. Then can downgrade the rest to a regular issue
OK Functionally things seem to work again. I'm leaving the issue open because it probably still needs further code review. But I'm removing the release blocker tag
Labels |
Removed:
?
|
and what about the FTP stuff?
Thats part of the update component and there has been nothing proposed for that at all
What's broken with the FTP stuff? As far as I'm concerned nothing should have changed there between J3.x and 4.x?
What's broken with the FTP stuff? As far as I'm concerned nothing should have changed there between J3.x and 4.x?
For a start if you select FTP then you dont get prompted for the ftp username and password
please close
Status | New | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-01-14 12:27:28 |
Closed_By | ⇒ | wilsonge | |
Labels |
Added:
No Code Attached Yet
Removed: ? |
I cleaned up the codestyle in #31493 so it is at least easy to read for anyone working on the above