[#31489] - [4.0] plugin installation order
- Fixed in Code Base
- 17 Dec 2020
- Medium
- Build: 4.0-dev
- # 31489
- Diff
- brianteeman:wed1
User tests: Successful: Unsuccessful:
This PR does two things
The first is simply to put the list of plugins to be installed back into alphabetical order. This makes it easier to maintain and find things in the database
The second is to set the plugin order
In general it probably doesn't matter at all what order the plugins are in but if you look at the ordering dropdown it looks a mess as many of the plugins have the same order number. Some of the oldest plugins have an ordering value but most just have a 0.
This PR adds a value starting at 1 for each plugin grouped by type
This is only for new installs
This is only for mysql (if approved I will update postgresql as well)
Example Before
Example After
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | SQL Installation |
| Labels |
Added:
?
|
||
Restarting drone doesn't help. RIPS: Failure: Number of issues exceeds sum threshold (3/0) @SniperSister @zero-24 can you have a look at RIPS thanks
Has this PR been updated to the latest 4.0-dev? Just restarting does not help with rips as it tests the same codebase.
It was the latest at the time it was submitted. I will update it again
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31489.
I have tested this item
Tested successfully.
Thank you for the fix
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31489.
This is only for mysql (if approved I will update postgresql as well)
Waiting with RTC since postgresql files are missing.
@richard67 as stated in the first post I am waiting to hear if its approved before spending the time to do the postgres version
| Category | SQL Installation | ⇒ | SQL Installation Postgresql |
@richard67 updated with postgres
We have 2 good tests with MySQL (or MariaDB), and I've reviewed the PR and can confirm that it does what it claims to do and that it's the same for MySQL and PostgreSQL beside the necessary difference in names quoting.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31489.
Any reason why this RTC pr has not been merged?
I'm not so sure that the order has no impact, I know that the languagefilter plugins could produce troubles if it's not the loaded before some other system plugins but can only name my own plugin.
Only one core type of plugins are impacted by the order. The installation plugins and that is why they are not ordered alphabetically in this PR.
There is an impact of the order with 3pd plugins. Some of them absolutely do need to be positioned before or after other plugins. This PR actually helps that as can be seen in the screenshots.
Also as soon as you move any plugin (before this PR) they are re-ordered anyway - proving that there is no impact
The alphaorder set here works for en-GB, not for other languages.
I get for French (some are en-GB below as they do not exist in 3.9.23 French pack)
Before patch:
after patch:
The point of the PR is not the order but the fact that they all have a unique number.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-12-17 16:09:09 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Consistent ordering seems like a good idea to me. Thanks!
thx
Can someone restart drone please