Feeling Lucky
?
?
?
[#31487] - [4.0] Incorrect language constant in installation files
- Fixed in Code Base
- 26 Nov 2020
- Medium
- Build: 4.0-dev
- # 31487
- Diff
- Kostelano:4.0-dev
User tests: Successful: Unsuccessful:
Summary of Changes
When installing Joomla 4, select the PostgreSQL type and enter the database name that starts with a number.
We get an error.
The constant appears two times in the files below.
PR fixes the problem.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Installation Language & Strings |
brianteeman
- comment
- 25 Nov 2020
An alternative that would avoid all the translations to be updated would be to update the constant in the two places it is used in the code
gostn
- comment
- 26 Nov 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31487.
infograf768
- comment
- 26 Nov 2020
Agree with @brianteeman
please rather modify
/Applications/MAMP/htdocs/newfolder/joomla40/installation/src/Helper/DatabaseHelper.php:238: return Text::_('INSTL_DATABASE_NAME_MSG_POSTGRESQL');
/Applications/MAMP/htdocs/newfolder/joomla40/libraries/src/Console/SetConfigurationCommand.php:314: $this->ioStyle->error(Text::_('INSTL_DATABASE_NAME_MSG_POSTGRESQL'));
to use INSTL_DATABASE_NAME_MSG_POSTGRES
| Labels |
Added:
?
?
|
||
| Category | Installation Language & Strings | ⇒ | Installation Libraries |
Kostelano
- comment
- 26 Nov 2020
DONE.
infograf768
- comment
- 26 Nov 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31487.
brianteeman
- comment
- 26 Nov 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31487.
| Status | Pending | ⇒ | Ready to Commit |
infograf768
- comment
- 26 Nov 2020
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31487.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-11-26 14:36:27 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
wilsonge
- comment
- 26 Nov 2020
Thanks!
I have tested this item✅ successfully on fb32c79
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31487.