? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
25 Nov 2020

PR for #30732

Summary

make sure the modern router uses a translatable string for 404 pages

Step 1

Make sure that you have SEF working
Make sure that you have modern routing enabled for com_content

Step 3

Go to a non existent page on the frontend

The error message says 404 URL Invalid

image

Step 4

Apply this pull request
Refresh the frontend

The error message says 404 page not found

image

avatar brianteeman brianteeman - open - 25 Nov 2020
avatar brianteeman brianteeman - change - 25 Nov 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Nov 2020
Category Libraries
avatar toivo toivo - test_item - 25 Nov 2020 - Tested successfully
avatar toivo
toivo - comment - 25 Nov 2020

I have tested this item successfully on 53b8520

Tested successfully in 3.9.23


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31486.

avatar toivo toivo - test_item - 25 Nov 2020 - Tested successfully
avatar gostn gostn - test_item - 25 Nov 2020 - Tested successfully
avatar gostn
gostn - comment - 25 Nov 2020

I have tested this item successfully on 53b8520


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31486.

avatar Quy Quy - change - 25 Nov 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 25 Nov 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31486.

avatar infograf768 infograf768 - change - 26 Nov 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-11-26 09:38:57
Closed_By infograf768
Labels Added: ? ?
avatar infograf768 infograf768 - close - 26 Nov 2020
avatar infograf768 infograf768 - merge - 26 Nov 2020
avatar infograf768
infograf768 - comment - 26 Nov 2020

Tks

avatar brianteeman
brianteeman - comment - 26 Nov 2020

Thanks

Add a Comment

Login with GitHub to post a comment