Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#31480] - Start reordering with 1 instead of 0

? ? Pending

User tests: Successful: Unsuccessful:

avatar HLeithner
HLeithner
24 Nov 2020

Pull Request for Issue #24008 .

Summary of Changes

Starts the ordering with 1 instead of 0, this allows to use getNextOrder in table store function for new items. This is used in com_modules.

Thx to @bembelimen for helping to find and fixing this issue.

Testing Instructions

  • npm ci
  • Test ordering in com_modules
  • Test ordering in any other component

Actual result BEFORE applying this Pull Request

  • com modules ordering does strange things
  • other components are working fine

Expected result AFTER applying this Pull Request

  • all components including com_modules are working fine

Documentation Changes Required

N/A

avatar HLeithner HLeithner - open - 24 Nov 2020
avatar HLeithner HLeithner - change - 24 Nov 2020
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Nov 2020
Category ⇒ JavaScript Repository NPM Change
avatar adj9
adj9 - comment - 25 Nov 2020
  • Done test installing the PR with Joomla!

The ID starts with 1, it's fine but still random.
Schermata 2020-11-25 alle 12 39 00

I don't have 109 modules.
Does PR manage the ID of the modules? Do I understand correctly?

avatar HLeithner
HLeithner - comment - 25 Nov 2020

did you run npm ci ?

avatar HLeithner HLeithner - change - 25 Nov 2020
The description was changed
avatar HLeithner HLeithner - edited - 25 Nov 2020
avatar brianteeman
brianteeman - comment - 25 Nov 2020

@adj9 the id of the module is an incremental field and never changes. So if you have 20 modules they will be numbered from 1 - 20 but if you delete one they do not get renumbered (obviously) and the next new module will still be id=21

avatar brianteeman
brianteeman - comment - 25 Nov 2020

Does PR manage the ID of the modules? Do I understand correctly?

No this is about the order of the modules - a different field altogether

avatar ceford ceford - test_item - 27 Nov 2020 - Tested successfully
avatar ceford
ceford - comment - 27 Nov 2020

I have tested this item ✅ successfully on ada81dd

I tested with the administrator modules in the cpanel position, full screen for dragging and narrow responsive screen for checking order. (Glitch on first reload? But...) Seems to work as described.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31480.

avatar gostn gostn - test_item - 27 Nov 2020 - Tested successfully
avatar gostn
gostn - comment - 27 Nov 2020

I have tested this item ✅ successfully on ada81dd

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31480.

avatar chmst chmst - change - 27 Nov 2020
Labels Added: ?
avatar chmst
chmst - comment - 27 Nov 2020

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31480.

avatar chmst
chmst - comment - 27 Nov 2020

RTC

avatar chmst chmst - change - 27 Nov 2020
Status Pending ⇒ Ready to Commit
avatar wilsonge wilsonge - change - 28 Nov 2020
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2020-11-28 02:29:49
Closed_By ⇒ wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 28 Nov 2020
avatar wilsonge wilsonge - merge - 28 Nov 2020
avatar wilsonge
wilsonge - comment - 28 Nov 2020

Thanks!

Add a Comment

Login with GitHub to post a comment