NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
13 Nov 2020

Pr for #29953

Summary of Changes

Ensure that a disabled dropdown select really looks disabled

Testing Instructions

Joomla 4.0-dev
Login to admin as super admin
Navigate Content -> Fields
Create a new text field - click save

Look at the Type dropdown

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

Documentation Changes Required

none

avatar brianteeman brianteeman - open - 13 Nov 2020
avatar brianteeman brianteeman - change - 13 Nov 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 13 Nov 2020
Category Administration Templates (admin) NPM Change
c9a1a72 13 Nov 2020 avatar brianteeman cs
avatar brianteeman brianteeman - change - 13 Nov 2020
Labels Added: NPM Resource Changed ?
4838308 13 Nov 2020 avatar brianteeman cs
avatar Quy Quy - test_item - 13 Nov 2020 - Tested successfully
avatar Quy
Quy - comment - 13 Nov 2020

I have tested this item successfully on 4838308


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31394.

avatar ceford ceford - test_item - 14 Nov 2020 - Tested successfully
avatar ceford
ceford - comment - 14 Nov 2020

I have tested this item successfully on 4838308

Needs npm ci - forgot the command to compile just css


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31394.

avatar Quy Quy - change - 14 Nov 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 14 Nov 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31394.

avatar richard67 richard67 - change - 14 Nov 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-11-14 18:19:30
Closed_By richard67
Labels Added: ?
avatar richard67 richard67 - close - 14 Nov 2020
avatar richard67 richard67 - merge - 14 Nov 2020
avatar richard67
richard67 - comment - 14 Nov 2020

Thanks!

avatar richard67
richard67 - comment - 14 Nov 2020

Needs npm ci - forgot the command to compile just css

@ceford npm run build:js for js and npm run build:css for CSS.

Add a Comment

Login with GitHub to post a comment