This shouldn't really be an issue because related methods in language class run keys through strtoupper().

true, but it should match the other methods/statements. 😄

We have multiple examples of this kind of code.
$this->toc[$key] = Text::_('COM_ADMIN_HELP_' . $value);
Text::_('COM_BANNERS_FIELD_VALUE_' . $purchaseTypes[$params->get('purchase_type')])
$label = empty($fieldSet->label) ? 'COM_CONFIG_' . $name . '_FIELDSET_LABEL' : $fieldSet->label; ?>
$lang_key = 'PLG_FINDER_STATISTICS_' . str_replace(' ', '_', $type->type_title);
<?php echo Text::_('COM_PRIVACY_HEADING_REQUEST_TYPE_TYPE_' . $item->request_type); ?>

etc. etc.

if we start adding strtoupper() to all such occurrences in core, this would add quite a work.

Welcome to propose patch.

@infograf768

• Not sure what you are showing me, all I know is that this method's code does not match its neighbours in the same class, which it should.
• The rest of the similiar statements in this class have strtoupper().
• Literally it just needs strtoupper() adding.

Welcome to propose patch = I dont know how to and I discovered this whilst building my first component so i need to finish that before learning something else. 😄

The samples above comes from core code in various places where strtoupper() is not used but it's working fine as @SharkyKZ righfully commented.

true, but it should match the other methods/statements

I would remove strtoupper() from other methods (consistency and less code) if nothing fails then.

This should be closed if no one is going to create the pr

We have a pull request #33072