Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#31377] - onExtensionAfterUpdate() in actionlog is missing strtoupper() on language string

?
avatar shoulders
shoulders
10 Nov 2020

Duplicate #31378 - This was casued by a Github 404 error, delete or close this issue.

If you look at the line

joomla-cms/plugins/actionlog/joomla/joomla.php

Lines 451 to 452 in ab62797

// If the extension type has it own language key, use it, otherwise, use default language key
if ($this->app->getLanguage()->hasKey('PLG_ACTIONLOG_JOOMLA_' . $extensionType . '_UPDATED'))

The translation string is not correctly converted in to a fully UPPERCASE string like

joomla-cms/plugins/actionlog/joomla/joomla.php

Lines 400 to 401 in ab62797

// If the extension type has it own language key, use it, otherwise, use default language key
if ($this->app->getLanguage()->hasKey(strtoupper('PLG_ACTIONLOG_JOOMLA_' . $extensionType . '_UNINSTALLED')))

Notes

  • So just adding strtoupper() to this onExtensionAfterUpdate() to match the similiar functions onExtensionAfterUninstall() and onExtensionAfterInstall() in this class will fix this.
  • The lack of this strtoupper() might cause the key lookup to fail.
avatar shoulders shoulders - open - 10 Nov 2020
avatar joomla-cms-bot joomla-cms-bot - change - 10 Nov 2020
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 10 Nov 2020
avatar shoulders shoulders - change - 10 Nov 2020
The description was changed
avatar shoulders shoulders - edited - 10 Nov 2020
avatar shoulders shoulders - change - 10 Nov 2020
The description was changed
avatar shoulders shoulders - edited - 10 Nov 2020
avatar Quy Quy - change - 10 Nov 2020
Status New ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2020-11-10 16:02:40
Closed_By ⇒ Quy
avatar Quy Quy - close - 10 Nov 2020

Add a Comment

Login with GitHub to post a comment