[#31374] - [4.0] Exclude tab workflow if workflow is not enabled
- Fixed in Code Base
- 3 Jul 2021
- Medium
- Build: 4.0-dev
- # 31374
- Diff
- chmst:workflow-categories
User tests: Successful: Unsuccessful:
Pull Request for Issue #31324 .
Summary of Changes
Exclude tab workflow in category edit, if workflow is not enabled for content
Testing Instructions
See #31324, switch on and off workflow in content options (integration)
Actual result BEFORE applying this Pull Request
Tab workflow in categotry is always visible
Expected result AFTER applying this Pull Request
Tab workflow in categories is ony visible if wirkflow is aneabled
Documentation Changes Required
no
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_categories |
I have tested this item
Tested successfully in Beta6-dev of 10 November
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31374.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31374.
| Labels |
Added:
?
|
||
@SharkyKZ, you are right, I have chanched the code.
@toivo , @ChristineWk please could you repeat your tests?
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31374.
I have tested this item
When workflows is turned off in Content - Options - Integration, creating a new category fails with the warning:
Field required: Workflows
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31374.
I have not tested this item.
Confirmed.
Test reverted.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31374.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31374.
I have tested this item
I have tested this item
When workflows is turned off in Content - Options - Integration, creating a new category fails with the warning:
Field required: Workflows
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31374.
I have tested this item
https://tinyurl.com/y33g4ppc
Getting "Call to undefined method" error on category page after applying the patch.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31374.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31374.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-02-03 09:28:29 |
| Closed_By | ⇒ | chmst |
| Status | Closed | ⇒ | New |
| Closed_Date | 2021-02-03 09:28:29 | ⇒ | |
| Closed_By | chmst | ⇒ |
| Status | New | ⇒ | Pending |
| Category | Administration com_categories | ⇒ | Administration com_categories com_content Libraries |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31374.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31374.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31374.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-07-03 21:59:05 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks!
This is still wrong.
I suspect that sharky is expecting the object to be removed from the form in the model rather than being ignored from rendering
Something wrong causes by this PR. Try to edit a category from com_banners, got this error message:
Call to undefined method Joomla\Component\Banners\Administrator\Extension\BannersComponent::getCategoryWorkflowContext()
This is wrong as already explained in #30345.