? ? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
10 Nov 2020

Pull Request for Issue #31367

Summary of Changes

Added scope row.
Taking off useless headers="categorylist_header_WHATEVER"
Display Written by and Hits in badge only when table headings are set to No in the list layout parameters.

Testing Instructions

Create some articles in the same category.Create a category list menu item.
Switch Table Headings to yes and no
Load menu item in frontend.

Actual result BEFORE applying this Pull Request

tableheadingsbefore

Expected result AFTER applying this Pull Request

tableheadings after

Screen Shot 2020-11-10 at 07 42 34

avatar infograf768 infograf768 - open - 10 Nov 2020
avatar infograf768 infograf768 - change - 10 Nov 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 Nov 2020
Category Front End com_content
avatar infograf768 infograf768 - change - 10 Nov 2020
The description was changed
avatar infograf768 infograf768 - edited - 10 Nov 2020
avatar toivo toivo - test_item - 10 Nov 2020 - Tested successfully
avatar toivo
toivo - comment - 10 Nov 2020

I have tested this item successfully on 094f67e

Tested successfully in Beta6-dev of 10 November.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31373.

avatar toivo
toivo - comment - 10 Nov 2020

I have tested this item successfully on 094f67e

Tested successfully in Beta6-dev of 10 November.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31373.

avatar infograf768 infograf768 - change - 10 Nov 2020
Labels Added: ?
avatar infograf768
infograf768 - comment - 10 Nov 2020

scope row now moved.
@toivo test is still OK as it does not change display.

avatar infograf768 infograf768 - alter_testresult - 10 Nov 2020 - toivo: Tested successfully
avatar chmst chmst - test_item - 10 Nov 2020 - Tested successfully
avatar chmst
chmst - comment - 10 Nov 2020

I have tested this item successfully on 7b61f7c

Not tested for voting columns


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31373.

avatar infograf768
infograf768 - comment - 12 Nov 2020

td modified to th as required

Also modified the display for Votes and Ratings depending on Table Headings display

Screen Shot 2020-11-12 at 09 34 44

Screen Shot 2020-11-12 at 09 34 22

Ratings should be displayed as stars in the same way as when displaying an article. No idea how to do that as we can have multiple onContentBeforeDisplay or onContentAfterDisplay methods in different plugins.
Therefore I left it as it was.

@chmst @Quy Please test again

avatar chmst chmst - test_item - 12 Nov 2020 - Tested successfully
avatar chmst
chmst - comment - 12 Nov 2020

I have tested this item successfully on 767c447


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31373.

avatar infograf768
infograf768 - comment - 13 Nov 2020

@toivo
Please test again.

avatar toivo toivo - test_item - 14 Nov 2020 - Tested successfully
avatar toivo
toivo - comment - 14 Nov 2020

I have tested this item successfully on 767c447

Tested successfully in Beta6-dev of 14 November.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31373.

avatar infograf768 infograf768 - change - 14 Nov 2020
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 14 Nov 2020

As last change was just deleting a forgotten headers, RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31373.

avatar infograf768
infograf768 - comment - 14 Nov 2020

As last change was just deleting a forgotten headers, RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31373.

avatar richard67 richard67 - change - 14 Nov 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-11-14 14:00:43
Closed_By richard67
Labels Added: ?
avatar richard67 richard67 - close - 14 Nov 2020
avatar richard67 richard67 - merge - 14 Nov 2020
avatar richard67
richard67 - comment - 14 Nov 2020

Thanks!

Add a Comment

Login with GitHub to post a comment