[#31349] - [4.0] Atum logo and login image alt [a11y]
- Fixed in Code Base
- 10 Nov 2020
- Medium
- Build: 4.0-dev
- # 31349
- Diff
- brianteeman:atum
User tests: Successful: Unsuccessful:
This PR applies the ALT text changes from #31318
In addition the related fields are now correctly grouped in a fieldset
Any comments about the layout will be ignored as that's an unrelated issue which we have a release blocker for
Testing
Testing is really easy. No npm, js or css involved.
Merge the pull request and then go to edit the atum template style and go to the image settings tab
You now have a new field and tweaked text
Please test three scenarios when adding a large log, a small logo and a login image
-
Image Description (Alt Text) = Empty
No Description = unchecked -
Image Description (Alt Text) = "some description"
No Description = unchecked -
Image Description (Alt Text) = Empty
No Description = checked
The expected behaviour for each of these tests is
<img src="filename.jpg"><img src="filename.jpg" alt="some description"><img src="filename.jpg" alt>
or<img src="filename.jpg" alt="">
PLEASE do not comment on what you think the code does but apply the PR and test it. Getting very tired of people blocking PR with their comments without actually testing the code.
cc @carcam
Votes
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings Templates (admin) |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31349.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31349.
| Labels |
Added:
?
?
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-11-10 10:20:28 |
| Closed_By | ⇒ | chmst | |
| Labels | |||
Thanks!
Thanks
I have tested this item✅ successfully on b7f157c
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31349.