[#31323] - [4.0] Accessible media field ALt Text
- Fixed in Code Base
- 7 Nov 2020
- Medium
- Build: 4.0-dev
- # 31323
- Diff
- brianteeman:imagefield
User tests: Successful: Unsuccessful:
This PR continues the awesome work of @astridx in #27712 by correcting the behaviour of the alt text and changing the strings to match the work done in #31318
Background
To read why this change is very important see #31318
Testing Part 1
Testing is really easy. No npm, js or css involved.
Merge the pull request and then create a content field of type media (default settings are fine)
Open an article the media field now has a third field and tweaked text to match #31318
Before
After
Testing Part 2
Please test three scenarios when adding an image
-
Image Description (Alt Text) = Empty
No Description = unchecked -
Image Description (Alt Text) = "some description"
No Description = unchecked -
Image Description (Alt Text) = Empty
No Description = checked
The expected behaviour for each of these tests is
1.<img loading="lazy" src="filename.jpg">
2. <img loading="lazy" src="filename.jpg" alt="some description">
3. <img loading="lazy" src="filename.jpg" alt >
or <img loading="lazy" src="filename.jpg" alt="">
PLEASE do not comment on what you think the code does but apply the PR and test it. Getting very tired of people blocking PR with their comments without actually testing the code.
cc @carcam
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings Libraries Front End Plugins |
| Labels |
Added:
?
?
|
||
No thanks
On Fri, 6 Nov 2020 at 16:58, Quy notifications@github.com wrote:
How about using a switcher instead checkbox to show the Alt Text field
when unchecked?—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#31323 (comment),
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJ4P4JO6EEA53ZPQ6B7TITSOQTMXANCNFSM4TMO6BLA
.
--
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31323.
I have tested this item
I have tested this item.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31323.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31323.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-11-07 08:21:17 |
| Closed_By | ⇒ | chmst | |
| Labels |
Added:
?
|
||
Thanks!
Thanks - just need all the others to be written and merged now.
How about using a switcher instead checkbox to show the Alt Text field when unchecked?