? ? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
6 Nov 2020

This PR continues the awesome work of @astridx in #27712 by correcting the behaviour of the alt text and changing the strings to match the work done in #31318

Background

To read why this change is very important see #31318

Testing Part 1

Testing is really easy. No npm, js or css involved.
Merge the pull request and then create a content field of type media (default settings are fine)
Open an article the media field now has a third field and tweaked text to match #31318

Before

image

After

image

Testing Part 2

Please test three scenarios when adding an image

  1. Image Description (Alt Text) = Empty
    No Description = unchecked

  2. Image Description (Alt Text) = "some description"
    No Description = unchecked

  3. Image Description (Alt Text) = Empty
    No Description = checked

The expected behaviour for each of these tests is

1.<img loading="lazy" src="filename.jpg">
2. <img loading="lazy" src="filename.jpg" alt="some description">
3. <img loading="lazy" src="filename.jpg" alt >
or <img loading="lazy" src="filename.jpg" alt="">

PLEASE do not comment on what you think the code does but apply the PR and test it. Getting very tired of people blocking PR with their comments without actually testing the code.

cc @carcam

avatar brianteeman brianteeman - open - 6 Nov 2020
avatar brianteeman brianteeman - change - 6 Nov 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 Nov 2020
Category Administration Language & Strings Libraries Front End Plugins
avatar brianteeman brianteeman - change - 6 Nov 2020
The description was changed
avatar brianteeman brianteeman - edited - 6 Nov 2020
avatar brianteeman brianteeman - change - 6 Nov 2020
The description was changed
avatar brianteeman brianteeman - edited - 6 Nov 2020
avatar brianteeman brianteeman - change - 6 Nov 2020
Labels Added: ? ?
avatar Quy
Quy - comment - 6 Nov 2020

How about using a switcher instead checkbox to show the Alt Text field when unchecked?

avatar brianteeman
brianteeman - comment - 6 Nov 2020

No thanks

On Fri, 6 Nov 2020 at 16:58, Quy notifications@github.com wrote:

How about using a switcher instead checkbox to show the Alt Text field
when unchecked?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#31323 (comment),
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJ4P4JO6EEA53ZPQ6B7TITSOQTMXANCNFSM4TMO6BLA
.

--
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

avatar pranotiTechjoomla pranotiTechjoomla - test_item - 7 Nov 2020 - Tested successfully
avatar pranotiTechjoomla
pranotiTechjoomla - comment - 7 Nov 2020

I have tested this item successfully on bfdc890


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31323.

avatar snehaM26 snehaM26 - test_item - 7 Nov 2020 - Tested successfully
avatar snehaM26
snehaM26 - comment - 7 Nov 2020

I have tested this item successfully on bfdc890

I have tested this item.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31323.
avatar alikon alikon - change - 7 Nov 2020
Status Pending Ready to Commit
avatar alikon
alikon - comment - 7 Nov 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31323.

avatar chmst chmst - change - 7 Nov 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-11-07 08:21:17
Closed_By chmst
Labels Added: ?
avatar chmst chmst - close - 7 Nov 2020
avatar chmst chmst - merge - 7 Nov 2020
avatar chmst
chmst - comment - 7 Nov 2020

Thanks!

avatar brianteeman
brianteeman - comment - 7 Nov 2020

Thanks - just need all the others to be written and merged now.

Add a Comment

Login with GitHub to post a comment