[#31322] - FeaturedButton fix
- Fixed in Code Base
- 18 Dec 2020
- Medium
- Build: 4.0-dev
- # 31322
- Diff
- Denitz:FeaturedButton_hard-coded_task_prefix
User tests: Successful: Unsuccessful:
Summary of Changes
FeaturedButton has hard-coded task prefix articles. and uses COM_CONTENT-related tip strings.
It should work similarly to PublishedButton.
Testing Instructions
Create your own FeaturedButton button with own task_prefix option.
Apply patch, ensure that feature/unfeature buttons work in backend articles.
Actual result BEFORE applying this Pull Request
See that articles. still exist in button HTML.
Expected result AFTER applying this Pull Request
Valid task name in custom button
Ensure that feature/unfeature buttons work in backend articles.
Documentation Changes Required
No.
Votes
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_content Language & Strings Libraries |
The button code makes custom tooltip option really complex, it's easier and completely enough to have the common tooltip title which will satisfy all components (JFEATURED/JUNFEATURED)
Go to Content > Featured Articles
Clicking the Featured icon does not toggle to Unfeatured.
| Labels |
Added:
?
?
|
||
The Featured Articles Feature button does Unfeature the article. But neither Featured nor Status buttons do anything when Workflows are enabled. That makes me suspect something is wrong. I guess that is a separate issue.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31322.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-12-18 03:53:27 |
| Closed_By | ⇒ | wilsonge |
Nice spot. Thanks!
I have tested this item✅ successfully on 616539d
Not sure exactly how best to create my own FeaturedButton. I just duplicated the few button lines in com_content/tmpl/articles/default.php and changed the task prefix. With the two buttons side by side the correct button worked normally to feature/unfeature an article.
An aside: I noticed that the Featured button in com_content has a different tooltip from that in com_contacs.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31322.