? ? Pending

User tests: Successful: Unsuccessful:

avatar Denitz
Denitz
6 Nov 2020

Summary of Changes

FeaturedButton has hard-coded task prefix articles. and uses COM_CONTENT-related tip strings.

It should work similarly to PublishedButton.

Testing Instructions

Create your own FeaturedButton button with own task_prefix option.

Apply patch, ensure that feature/unfeature buttons work in backend articles.

Actual result BEFORE applying this Pull Request

See that articles. still exist in button HTML.

Expected result AFTER applying this Pull Request

Valid task name in custom button

Ensure that feature/unfeature buttons work in backend articles.

Documentation Changes Required

No.

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
3.00

616539d 6 Nov 2020 avatar Denitz fix
avatar Denitz Denitz - open - 6 Nov 2020
avatar Denitz Denitz - change - 6 Nov 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 Nov 2020
Category Administration com_content Language & Strings Libraries
avatar ceford ceford - test_item - 7 Nov 2020 - Tested successfully
avatar ceford
ceford - comment - 7 Nov 2020

I have tested this item successfully on 616539d

Not sure exactly how best to create my own FeaturedButton. I just duplicated the few button lines in com_content/tmpl/articles/default.php and changed the task prefix. With the two buttons side by side the correct button worked normally to feature/unfeature an article.

An aside: I noticed that the Featured button in com_content has a different tooltip from that in com_contacs.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31322.

avatar Denitz
Denitz - comment - 8 Nov 2020

The button code makes custom tooltip option really complex, it's easier and completely enough to have the common tooltip title which will satisfy all components (JFEATURED/JUNFEATURED)

avatar Quy
Quy - comment - 20 Nov 2020

Go to Content > Featured Articles
Clicking the Featured icon does not toggle to Unfeatured.

avatar Denitz Denitz - change - 23 Nov 2020
Labels Added: ? ?
avatar Denitz
Denitz - comment - 23 Nov 2020

@Quy Fixed in featured articles view as well. Checked all FeaturedButton usages, there are only two - both have the task_prefix option now.

avatar ceford
ceford - comment - 23 Nov 2020

The Featured Articles Feature button does Unfeature the article. But neither Featured nor Status buttons do anything when Workflows are enabled. That makes me suspect something is wrong. I guess that is a separate issue.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31322.

avatar Denitz
Denitz - comment - 23 Nov 2020

@ceford Yes, separate, it looks like Feature and State columns should be not displayed if Workflows are enabled because all state-related and feature-related changes are only possible with a drop-down in Stages column.

avatar wilsonge wilsonge - change - 18 Dec 2020
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-12-18 03:53:27
Closed_By wilsonge
avatar wilsonge wilsonge - close - 18 Dec 2020
avatar wilsonge wilsonge - merge - 18 Dec 2020
avatar wilsonge
wilsonge - comment - 18 Dec 2020

Nice spot. Thanks!

Add a Comment

Login with GitHub to post a comment