[#31290] - [4.0] Move to Dart SASS
- Fixed in Code Base
- 5 Nov 2020
- Medium
- Build: 4.0-dev
- # 31290
- Diff
- C-Lodder:dart
User tests: Successful: Unsuccessful:
Summary of Changes
Libsass and node-sass are deprecated, so this PR moves J4 over to Dart SASS.
This will also fix not being able to run CSS related build scripts for Joomla 4 on NodeJS 15+
Testing Instructions
Run npm run build:css from your terminal
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) NPM Change JavaScript Repository Front End Templates (site) |
Is it correct that there is a new file in this PR build/media_source/system/scss/_jalert.scss
@brianteeman No, it should be removed.
| Labels |
Added:
NPM Resource Changed
?
|
||
done
I have tested this item
Tested OK providing that Composer dependency phpcodesniffer-composer-installer is updated as I use composer 2.
I don't PR this update as I can't test on a lesser version of Composer (i.e Composer 1.x). But it is ready if needed.
composer 2.0.4
npm 6.14.8
node v15.0.1
PHP 7.4.9
macOS Catalina
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31290.
| Labels |
Added:
Conflicting Files
|
||
I have tested this item
No issues on NPM build. Checked a new install and everything functions as expected.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31290.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31290.
| Status | Pending | ⇒ | Ready to Commit |
RTC.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31290.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-11-05 09:57:49 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
Removed: Conflicting Files |
||
Thanks!
please fix cs @C-Lodder thx