[#31283] - [4.0] TinyMCE & Codemirror updates with new lineheight for tinymce
- Fixed in Code Base
- 11 Nov 2020
- Medium
- Build: 4.0-dev
- # 31283
- Diff
- brianteeman:tinymce55
User tests: Successful: Unsuccessful:
This PR updates Tinymce and codemirror to the latest releases
For codemirrorir just fixes some bugs (https://codemirror.net/doc/releases.html)
TinyMCE has a few new possibilities (https://www.tiny.cloud/docs/release-notes/release-notes55/) and I have implemented the new lineheight button and added it to the advanced preset
To apply the pr you will need to run npm i
In the tinmymce editor plugin go to set 0 and click on use advanced preset
You will now see the new button
And / Or drag the new button from the list of available buttons
And then test it in the editor itself
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change Front End Plugins |
The inline style is from tinymce, not our integration. Unless I did something very wrong.
I have tested this item
I tried to install the PR with Joomla beta6. After the installation, I tested the plugin and the use of TinyMCE.
The new bar is
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31283.
| Labels |
Added:
NPM Resource Changed
?
|
||
| Category | JavaScript Repository NPM Change Front End Plugins | ⇒ | Administration com_config JavaScript Repository NPM Change Libraries Front End Plugins Unit Tests |
@brianteeman it seens the last commits now includes unintended changes?
DOH
| Labels |
Added:
?
|
||
| Category | JavaScript Repository NPM Change Front End Plugins Administration com_config Libraries Unit Tests | ⇒ | JavaScript Repository NPM Change Front End Plugins |
Looks good (I'm not sure about the other changes in the package.json are expected but i know to less about that kind of things) The files / commits i saw earlier are now gone. Thanks!
| Labels |
Removed:
?
|
||
I have tested this item
Confirmed new icon is available as well as that it functions as expected.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31283.
gostn
- | Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31283.
@brianteeman need you to resolve the conflicts here with your other PR I merged
| Labels |
Added:
?
|
||
Should be correct now. Knew that was going to happen but no way to avoid it
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-11-11 09:28:30 |
| Closed_By | ⇒ | laoneo |
Thanks!
Thanks
@brianteeman it's really disturbing that Joomla's tinyMCE integration still allows inline styles. Not that I didn't try to change that: #14456