[#31262] - [4.0] Remove FontAwesome from main template file
- Fixed in Code Base
- 29 Oct 2020
- Medium
- Build: 4.0-dev
- # 31262
- Diff
- SharkyKZ:j4/scss/fontawesome
User tests: Successful: Unsuccessful:
Closes #31257.
Summary of Changes
Removes FA from main Cassiopeia template file.
Testing Instructions
Apply patch.
Run node build/build.js --compile-css.
Browse some frontend pages and check that icons appear correctly.
Expected result AFTER applying this Pull Request
Works like before.
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository Front End Templates (site) NPM Change |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31262.
I have tested this item
For information: fa is used in mod_breadcrumbs, mod_finder, mod_login and mod_tags_popular. I only looked at the login form and the smart search form (with button).
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31262.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-10-29 09:29:31 |
| Closed_By | ⇒ | chmst | |
| Labels |
Added:
NPM Resource Changed
?
|
||
Thanks!
Please correct
@import "../../../../../media/vendor/fontawesome-free/scss/brands";
should be last
@infograf768 it was the same before but I'll have a look. What issue does this cause?
awesome free overrides brands
we lose icon-joomla
see #30707 (comment)
please check author and other modules, I think this is going to break them if FA is NOT included in the template because they use FA. tbh I've not tested this yet, this is just based on code review