?
avatar SharkyKZ
SharkyKZ
28 Oct 2020

What needs to be fixed

For some reason FontAwesome is still stuffed in main template files but it should be (and is) loaded from media/vendor directory.

Why this should be fixed

Bad code, bad frontend performance.

How would you fix it

Remove from template.css.

Side Effects expected

No.

avatar SharkyKZ SharkyKZ - open - 28 Oct 2020
avatar joomla-cms-bot joomla-cms-bot - change - 28 Oct 2020
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 28 Oct 2020
avatar SharkyKZ SharkyKZ - change - 28 Oct 2020
The description was changed
avatar SharkyKZ SharkyKZ - edited - 28 Oct 2020
avatar SharkyKZ SharkyKZ - change - 28 Oct 2020
The description was changed
avatar SharkyKZ SharkyKZ - edited - 28 Oct 2020
avatar N6REJ
N6REJ - comment - 28 Oct 2020

@SharkyKZ can you clarify please? I see that its loaded in

but don't see that happening in the code.
Removing it from /template.scss crashes FA

avatar SharkyKZ SharkyKZ - change - 28 Oct 2020
Status New Closed
Closed_Date 0000-00-00 00:00:00 2020-10-28 20:36:15
Closed_By SharkyKZ
avatar SharkyKZ SharkyKZ - close - 28 Oct 2020
avatar SharkyKZ
SharkyKZ - comment - 28 Oct 2020

This is only in Cassiopeia. Atum loads it correctly only once.

Closing as there is PR #31262.

Add a Comment

Login with GitHub to post a comment