User tests: Successful: Unsuccessful:
Status | New | ⇒ | Pending |
Category | ⇒ | JavaScript Administration com_media NPM Change |
Labels |
Added:
NPM Resource Changed
?
|
How to fix with the untranslated string when not one of the image extensions such as PDF?
Well what I did here needs to be repeated for all the types, eg video, audio, documents
const imageExtensions = api.imagesExtensions;
const videoExtensions = api.videoExtensions;
const audioExtensions = api. audioExtensions;
const docExtensions = api. docExtensions;
Of course this requires the appropriate changes in the Api.js and some fields in the com_media options to handle video, audio and docs...
And then some more changes in the vue files to handle properly all these files (eg the fix in this PR is not fixing the missing thumb for the svg)
I have tested this item
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC
@dgrammatiko
api question for ignorant people:
Where are the options.imagesExtensions
(and similar for video which is for now limited to mp4, etc.) fetched from in Api.es6 ? Link to the code please.
@infograf768 follow the files touched here, eg
Api: line 26 in administrator/components/com_media/resources/scripts/app/Api.es6.js
which is the data that is passed in the template: line 47 in administrator/components/com_media/tmpl/media/default.php
which is the options from
joomla-cms/administrator/components/com_media/config.xml
Lines 68 to 76 in 5eec638
Obviously video, audio and docs doesn't exist in the config.xml neither in the template neither in the Api (in the Api everything was hardcoded before this PR, but still there is work to be done for video, audio and docs)
Got it. Thanks.
Merging this and hopefully you get some time to follow up. ;)
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-10-27 06:07:56 |
Closed_By | ⇒ | infograf768 | |
Labels |
Added:
?
|
Tks.
How to fix with the untranslated string when not one of the image extensions such as PDF?