[#31213] - [4.0] [NO CACHE] Fix js console error
- Fixed in Code Base
- 23 Oct 2020
- Medium
- Build: 4.0-dev
- # 31213
- Diff
- dgrammatiko:4.0-dev-jtools-fix
User tests: Successful: Unsuccessful:
Pull Request for Issue #31158 (comment) .
Summary of Changes
Nodelist is not an array, always convert it to array. Fix the subform custom Element.
Testing Instructions
Go to plugin tinyMCE's edit page.
- No console error
- the
External Plugin URLsis working as expected (add new, remove, drag and drop)
Actual result BEFORE applying this Pull Request
console error, subform broken
Expected result AFTER applying this Pull Request
subform is working as expected
Documentation Changes Required
Nope, bug fix
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
| Labels |
Added:
NPM Resource Changed
?
|
||
| Category | JavaScript Repository NPM Change | ⇒ | JavaScript Repository NPM Change Front End Plugins |
| Title |
|
||||||
Beside that this should be fixed is there a way to use a sasscompiler that doesn't need python2?
Yes, webassembly. But a bit slower then again way more portable
how does webassembly help compling scss to css? I mean webassembly is a "browser" vm and can't compile scss or did I missed something?
Anyway we are using current node version with alpine linux which is both bleeding edge... so we have to move to something more settled.
btw. can you please split npm update from this pr, thanks
| Category | JavaScript Repository NPM Change Front End Plugins | ⇒ | JavaScript Repository NPM Change |
@HLeithner node updates reverted
I mean webassembly is a "browser" vm and can't compile scss or did I missed something?
Javascript is javascript, cli or browser is minor. Anyways we are already using webassebly for zopfli:
https://www.npmjs.com/package/@gfx/zopfli
for the same reason: #23385 (comment)
I have no problem with webassembly but we need a software to use webassembly to compile sass to css (replacing node-sass) or?
I have no problem with webassembly but we need a software to use webassembly to compile sass to css (replacing node-sass) or?
Actually scrap the idea, I had the impression that node-sass was already providing a wasm version but it seems that this is not the case yet: sass/node-sass#2011
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31213.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-10-23 19:44:52 |
| Closed_By | ⇒ | wilsonge |
Merging on the test + review. Thanks!
@HLeithner it seems the Drone OS was updated (?) and it is missing Python 2 and thus it cannot compile nodesass: