NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
22 Oct 2020

Fixes #31091, at least in some part.

Summary of Changes

Moves some SCSS files back to media folder so all SCSS files are shipped and CSS can be compiled in production environment.

Testing Instructions

Testing BEFORE result requires a built package like nightly or beta. For testing AFTER result download the package from the link below this comment.

Download scssphp from https://github.com/scssphp/scssphp (bad idea, I know, but it's fine for testing purposes).
Use scssphp to compile some file, e.g. templates/cassiopeia/scss/template.scss.

Actual result BEFORE applying this Pull Request

CSS compilation fails because of missing files:

../../../build/media_source/system/scss/icomoon` file not found for @import: ../templates/cassiopeia/scss/template.scss on line 21, at column 1

Expected result AFTER applying this Pull Request

CSS file compiled.

Documentation Changes Required

No.

avatar SharkyKZ SharkyKZ - open - 22 Oct 2020
avatar SharkyKZ SharkyKZ - change - 22 Oct 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 Oct 2020
Category Administration Templates (admin) NPM Change JavaScript Repository Front End Templates (site)
avatar SharkyKZ SharkyKZ - change - 22 Oct 2020
The description was changed
avatar SharkyKZ SharkyKZ - edited - 22 Oct 2020
avatar SharkyKZ SharkyKZ - change - 22 Oct 2020
Labels Added: NPM Resource Changed ?
avatar SharkyKZ SharkyKZ - change - 22 Oct 2020
The description was changed
avatar SharkyKZ SharkyKZ - edited - 22 Oct 2020
avatar dgrammatiko
dgrammatiko - comment - 22 Oct 2020

Please DON'T reintroduce the media folder in the repo, there's another way to move the scss files to media (in the init module)

avatar SharkyKZ
SharkyKZ - comment - 22 Oct 2020

I wanted to avoid having duplicate files in the working directory. This makes things complicated because assets needs to be copied after affected SCSS files are modified (because other SCSS files reference files from media directory). But OK.

avatar dgrammatiko
dgrammatiko - comment - 22 Oct 2020

This makes things complicated because assets needs to be copied after affected SCSS files are modified (because other SCSS files reference files from media directory)

I'll have to update the code for the tooling anyhow, but good to know what the requirements (for scss) are...

avatar dgrammatiko
dgrammatiko - comment - 25 Oct 2020

@SharkyKZ please undo the changes in the build tools modules. I 've updated them in #31221 to always ship and update as necessary the scss files per compilation

avatar SharkyKZ SharkyKZ - change - 2 Nov 2020
Labels Added: Conflicting Files
avatar SharkyKZ SharkyKZ - change - 11 Dec 2020
Labels Removed: Conflicting Files
avatar SharkyKZ SharkyKZ - change - 19 Feb 2021
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2021-02-19 06:03:05
Closed_By SharkyKZ
avatar SharkyKZ SharkyKZ - close - 19 Feb 2021

Add a Comment

Login with GitHub to post a comment