[#31191] - [4.0] Atum font sizes
- Closed
- 22 Oct 2020
- Medium
- Build: 4.0-dev
- # 31191
- Diff
- brianteeman:fonts
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success Download Prebuilt packages are available for download. Details
- Failure continuous-integration/drone/pr Build is failing Details
User tests: Successful: Unsuccessful:
PR for #31184
I took a look at this to create a PR the correct way for bootstrap scss
We should just have to change one variable
$font-size-base: 0.875rem; //instead of 1rem
But the rest of the font variables have not been defined correctly (probably based on bs4 beta1?) and they should be changed as well to be relative to this variable.
See the commit to bootstrap 3 years ago where this was done twbs/bootstrap#24060
There may be other font sizes in our scss that need to be updated to use this variable - I have not checked yet i believe I have done them all now but I deliberately ignored anything to do with icon fonts
I have no opinion on a base font size of 16px (before) and 14px (with this PR)
To test you will need to run npm ci or node build.js --compile-css
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) NPM Change |
| Category | Administration Templates (admin) NPM Change | ⇒ | Administration Templates (admin) NPM Change JavaScript Repository Layout Libraries Modules Front End Templates (site) |
The changes looks good, is there any a11y requirement based on font size? I know, that is should be possible to resize up to 200% without broken layout, but is there any min size?
PS: did you add other PRs into your PR? The JS stuff looks irrelevant?
grrh I updated the branch as requested and it looks like I did something wrong at the same time.
Regarding accessibility there are no rules or even recommendations about font sizes either minimum or maximum. The rules that applies are regarding contrast and a recommendation to use rem units to help scale content with a user’s personal preferences.
@bembelimen @richard67 the unrelated changes are coming from #31158 but they are already merged so I dont understand why they are showing up here
No idea either why they show up.
Closing and will create a new pr with a new branch
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-10-22 15:15:10 |
| Closed_By | ⇒ | brianteeman |
@brianteeman Could you update the branch for this PR with latest 4.0-dev of the CMS? Currently scss-cs is failing in Drone, but not due to code style of your PR. It seems the scss linter can't be started due to recently merged changes in the 4.0-dev branch of the CMS. In case if your 4.0-dev branch was not up to date with this when you have created the branch for this PR, this might be the reason. Thanks in advance.