?
avatar N6REJ
N6REJ
20 Oct 2020

PR #29571 breaks admin login.

Steps to reproduce the issue

log into admin on working install
pull latest commits from 4.0-dev
try logging into admin
notice nothing happens.

Expected result

can login admin

Actual result

login button does nothing.

System information (as much as possible)

4.0-dev 19oc20 1900cst pull

Additional comments

reverting commit allows logging in again
ran both composer install & npm ci but didn't fix the issue.

avatar N6REJ N6REJ - open - 20 Oct 2020
avatar joomla-cms-bot joomla-cms-bot - change - 20 Oct 2020
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 20 Oct 2020
avatar N6REJ N6REJ - change - 20 Oct 2020
Title
Revert PR #29571
[4.0] Revert PR #29571
avatar N6REJ N6REJ - edited - 20 Oct 2020
avatar N6REJ N6REJ - change - 20 Oct 2020
The description was changed
avatar N6REJ N6REJ - edited - 20 Oct 2020
avatar SharkyKZ
SharkyKZ - comment - 20 Oct 2020

I can't reproduce the issue.

avatar richard67
richard67 - comment - 20 Oct 2020

@SharkyKZ On a new install of current 4.0-dev I can't reproduce either.

But as @N6REJ wrote, he has pulled the changes on an existing installation and then had the issue.

So maybe we will have an issue when not making a new installation but updating?

=> It needs to test if a J4 Beta 4 can be updated to latest nightly J4 build (which includes #29571 ) to see if there is an issue when not having made a new installation.

In addition it should also be tested in a 3.10 can be properly updated to latest nightly J4 build without running into the issue.

I'll try to find time later for testing that, but if someone else could test that, too, it would be safer because I might make mistakes.

avatar SharkyKZ
SharkyKZ - comment - 20 Oct 2020

My guess you need to clear browser cache. If you're using some weird browser, #31169 might help.

avatar brianteeman
brianteeman - comment - 20 Oct 2020

Can not confirm

avatar N6REJ N6REJ - change - 20 Oct 2020
Status New Closed
Closed_Date 0000-00-00 00:00:00 2020-10-20 19:16:47
Closed_By N6REJ
avatar N6REJ N6REJ - close - 20 Oct 2020
avatar N6REJ
N6REJ - comment - 20 Oct 2020

idk what happened.. its working fine now.

Add a Comment

Login with GitHub to post a comment