Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#31164] - [4.0] Fix wrong line break in params value in postgresql/base.sql caused by PR #30823

? ? Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
19 Oct 2020

Pull Request for Issue #30823 (comment).

Summary of Changes

This pull request (PR) fixes a wrong line break in the params value of an insert statement which came into the installation SQL script "base.sql" for PostgreSQL with the merge of PR #30823 .

See the review comment referred above.

As you can see, system tests were passing with that erroneous line break, so it did not cause an SQL error on installation, but it is at least a code style error so to say.

Testing Instructions

  1. Check that system tests on PostgreSQL are passing in Drone.

  2. Code review: Compare the part of code changed by this PR here with the same SQL statement in the same script for MySQL.

https://github.com/joomla/joomla-cms/blob/4.0-dev/installation/sql/mysql/base.sql#L163

Actual result BEFORE applying this Pull Request

In the script for PostgreSQL there is a line break:

https://github.com/joomla/joomla-cms/blob/4.0-dev/installation/sql/postgresql/base.sql#L169-L170

Expected result AFTER applying this Pull Request

In the script for PostgreSQL there is no erroneous line break, so it looks the same as the script for MySQL:

joomla-cms/installation/sql/postgresql/base.sql

Lines 169 to 170 in 2bc9e22

(0, 'com_content', 'component', 'com_content', '', 1, 1, 0, 1, 1, '', '{"article_layout":"_:default","show_title":"1","link_titles":"1","show_intro":"1","show_category":"1","link_category":"1","show_parent_category":"0","link_parent_category":"0","show_author":"1","link_author":"0","show_create_date":"0","show_modify_date":"0","show_publish_date":"1","show_item_navigation":"1","show_vote":"0","show_tags":"1","show_readmore":"1","show_readmore_title":"1","readmore_limit":"100","show_hits":"1","show_noauth":"0","show_publishing_options":"1","show_article_options":"1","save_history":"1","history_limit":10,"show_urls_images_frontend":"0","show_urls_images_backend":"1","targeta":0,"targetb":0,"targetc":0,"float_intro":"left","float_fulltext":"left","category_layout":"_:blog","show_category_title":"0","show_description":"0","show_description_image":"0","maxLevel":"1","show_empty_categories":"0","show_no_articles":"1","show_subcat_desc":"1","show_cat_num_articles":"0","show_base_description":"1","maxLevelcat":"-1","show_empty_categories_cat":"0","show_subcat_desc_cat":"1","show_cat_num_articles_cat":"1","num_leading_articles":"1","num_intro_articles":"4","num_links":"4","show_subcategory_content":"0","link_intro_image":"0","show_pagination_limit":"1","filter_field":"hide","show_headings":"1","list_show_date":"0","date_format":"","list_show_hits":"1","list_show_author":"1","orderby_pri":"order","orderby_sec":"rdate","order_date":"published","show_pagination":"2","show_pagination_results":"1","show_feed_link":"1","feed_summary":"0"}', '', 0, 0),
(0, 'com_config', 'component', 'com_config', '', 1, 1, 0, 1, 1, '', '{"filters":{"1":{"filter_type":"NH","filter_tags":"","filter_attributes":""},"9":{"filter_type":"NH","filter_tags":"","filter_attributes":""},"6":{"filter_type":"BL","filter_tags":"","filter_attributes":""},"7":{"filter_type":"BL","filter_tags":"","filter_attributes":""},"2":{"filter_type":"NH","filter_tags":"","filter_attributes":""},"3":{"filter_type":"BL","filter_tags":"","filter_attributes":""},"4":{"filter_type":"BL","filter_tags":"","filter_attributes":""},"5":{"filter_type":"BL","filter_tags":"","filter_attributes":""},"8":{"filter_type":"NONE","filter_tags":"","filter_attributes":""}}}', '', 0, 0),

Documentation Changes Required

None.

avatar richard67 richard67 - open - 19 Oct 2020
avatar richard67 richard67 - change - 19 Oct 2020
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 Oct 2020
Category ⇒ Postgresql SQL Installation
avatar richard67 richard67 - change - 19 Oct 2020
The description was changed
avatar richard67 richard67 - edited - 19 Oct 2020
avatar richard67 richard67 - change - 19 Oct 2020
The description was changed
avatar richard67 richard67 - edited - 19 Oct 2020
avatar richard67 richard67 - change - 19 Oct 2020
The description was changed
avatar richard67 richard67 - edited - 19 Oct 2020
avatar richard67
richard67 - comment - 19 Oct 2020

@alikon As you are an SQL expert: Could you test by review?

@brianteeman Could you give it a test, too?

Thanks in advance.

avatar richard67 richard67 - change - 19 Oct 2020
The description was changed
avatar richard67 richard67 - edited - 19 Oct 2020
avatar brianteeman brianteeman - test_item - 19 Oct 2020 - Tested successfully
avatar brianteeman
brianteeman - comment - 19 Oct 2020

I have tested this item ✅ successfully on 2bc9e22

obvious fix - by code review

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31164.

avatar N6REJ N6REJ - test_item - 19 Oct 2020 - Tested successfully
avatar N6REJ
N6REJ - comment - 19 Oct 2020

I have tested this item ✅ successfully on 2bc9e22

Reviewed no line break present.
passes drone.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31164.

avatar richard67 richard67 - change - 19 Oct 2020
Status Pending ⇒ Ready to Commit
avatar richard67
richard67 - comment - 19 Oct 2020

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31164.

avatar richard67 richard67 - change - 19 Oct 2020
Labels Added: ? ?
avatar Quy Quy - change - 19 Oct 2020
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2020-10-19 21:31:13
Closed_By ⇒ Quy
Labels
avatar Quy Quy - close - 19 Oct 2020
avatar Quy Quy - merge - 19 Oct 2020
avatar Quy
Quy - comment - 19 Oct 2020

Thanks.

avatar richard67
richard67 - comment - 19 Oct 2020

Thanks.

Add a Comment

Login with GitHub to post a comment