Feeling Lucky
NPM Resource Changed
?
[#31158] - [4.0] More cleanup on the jstools
- Fixed in Code Base
- 21 Oct 2020
- Medium
- Build: 4.0-dev
- # 31158
- Diff
- dgrammatiko:4.0-dev-cleanup-jstools
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
- Remove the .eslintignore
- Fix the eslint errors on the remaining WebComponents
- Add a try/catch for any Json.parse()
- Favour functional forEach over for loops
Testing Instructions
All fields are working as before
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
| Labels |
Added:
NPM Resource Changed
?
|
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-10-21 16:23:00 |
| Closed_By | ⇒ | wilsonge |
wilsonge
- comment
- 21 Oct 2020
LGTM! Thanks!
Quy
- comment
- 22 Oct 2020
@dgrammatiko Can you please look into this? Thanks.
To reproduce, go to Global Configuration > Users > Email Domain Options and add a row.
Uncaught TypeError: rows.forEach is not a function
getRows http://localhost/joomla-cms-4.0-dev/media/system/js/fields/joomla-field-subform.js:150
JoomlaFieldSubform http://localhost/joomla-cms-4.0-dev/media/system/js/fields/joomla-field-subform.js:84
<anonymous> http://localhost/joomla-cms-4.0-dev/media/system/js/fields/joomla-field-subform.js:585
<anonymous> http://localhost/joomla-cms-4.0-dev/media/system/js/fields/joomla-field-subform.js:586c
Hey @wilsonge if you get some free time can you check this one? Thanks